diff options
author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2018-06-09 08:25:03 +0300 |
---|---|---|
committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2018-06-14 07:59:05 +0000 |
commit | 1dc5ce31ced5baee363f6d30049ca418ce414866 (patch) | |
tree | 7b49e7ceed093073e1c434c77401bb6c0469037f /util/romcc/tests/simple_test41.c | |
parent | 3414f6035b5af0ef004742f0ba91fbad266a6162 (diff) |
coreinfo: Skip unpopulated PCI functions
Per PCI specification, function 0 must be present,
so functions 1 to 7 can be skipped in this case.
For a device that is not multi-function, it may not
decode function number in the hardware at all. To
avoid registering such a device eight times, skip
scanning functions 1 to 7.
Without the latter fix, a single-function PCI bridge
may call pci_scan_bus() second time and secondary
side devices would get appended second time in the
array devices[]. At that point, quicksort() apparently
hits an infinite recursion loop.
Since pci_scan_bus() is called in part of the early
modules->init() sequence early in main(), the errors
here left coreinfo payload completely silent when
PCI module was built-in on affected system.
Terminal screen was cleared, though.
Change-Id: Ifc6622f050b98afb7196de0cc3a863c4cdfa6c94
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/26990
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'util/romcc/tests/simple_test41.c')
0 files changed, 0 insertions, 0 deletions