diff options
| author | Paul Fagerburg <pfagerburg@chromium.org> | 2019-09-25 09:31:57 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-09-30 11:42:01 +0000 |
| commit | cad708d210196690c2cc537004e556b075dc758c (patch) | |
| tree | 362e846e620ee1091c77dcf153ae0728438479cd /util/amdtools/README | |
| parent | 2422f8c21e4590dcf75239583099a467f79f9878 (diff) | |
util/mb/google/hatch: fix style issues in shell script
* Use all caps for variables.
* Use a single exit code for failures.
* No need to popd before exiting the script.
* Do ${var,,} and ${var^^} into variables instead of using it everywhere.
* Add more punctuation in comments.
* Specify LC_ALL=C so that upper/lower case show the desired behavior.
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Change-Id: I63aa0aa633f36b9543e809fc42fac955da5960a3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35605
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'util/amdtools/README')
0 files changed, 0 insertions, 0 deletions