diff options
| author | George Burgess IV <gbiv@google.com> | 2024-07-10 09:41:03 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-07-12 16:01:54 +0000 |
| commit | 794934cbeebb586847c98cc3d7ea04fa09a7330b (patch) | |
| tree | 1390e6a40d4a9441ebac4bcd8e99b03fe2c60931 /util/amdfwtool/amdfwtool.h | |
| parent | 04937a9a20e7cb9d020c74a942b9894c5bc5556a (diff) | |
amdfwtool: make fields unsigned
The value stored in `gen` is only ever `1` or `0`. Storing `1` causes
Clang to warn, since the only valid values for a 1-bit int are -1 and 0:
```
amdfwtool.c:1487:27: error: implicit truncation from 'int' to a one-bit
wide bit-field changes value from 1 to -1
[-Werror,-Wsingle-bit-bitfield-constant-conversion]
1487 | amd_romsig->efs_gen.gen = EFS_BEFORE_SECOND_GEN;
```
TEST=Rebuilt coreboot; no warning was emitted.
Change-Id: Ibd83be8302e8a717db7e7dc86a403b5648976586
Signed-off-by: George Burgess IV <gbiv@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83412
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'util/amdfwtool/amdfwtool.h')
| -rw-r--r-- | util/amdfwtool/amdfwtool.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 1dc445c3ab..b2fd2c0006 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -143,8 +143,8 @@ typedef enum _amd_addr_mode { } amd_addr_mode; struct second_gen_efs { /* todo: expand for Server products */ - int gen:1; /* Client products only use bit 0 */ - int reserved:31; + uint32_t gen:1; /* Client products only use bit 0 */ + uint32_t reserved:31; } __attribute__((packed)); #define EFS_SECOND_GEN 0 |