summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorChristian Walter <christian.walter@9elements.com>2020-05-06 09:18:37 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-05-26 15:01:29 +0000
commite6e9fa6ef90bc62d645da942f3bdc7bdeb1c1930 (patch)
treea490f437351fbd91424ec29224a646780bf5ffbd /src
parent9ea70c02cd0e5e28f38136ebbb6dbad72ad177c7 (diff)
soc/intel/cannonlake: Add VrPowerDeliveryDesign to chip options
Intel introduced the UPD VrPowerDeliveryDesign with Cannon Lake. The BIOS needs to program VrPowerDeliverDesign configuration per platform according to the platform capabilities to avoid incorrect electrial/power parameters. This is only added for Cannon Lake. Refer to document 599797 for more details. Change-Id: I89b8dceb40fa6a9dc67b218e91bf728ff928b5a0 Signed-off-by: Christian Walter <christian.walter@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41081 Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/cannonlake/chip.h4
-rw-r--r--src/soc/intel/cannonlake/fsp_params.c4
2 files changed, 8 insertions, 0 deletions
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 4f015a71f7..f6ec7ce7cb 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -413,6 +413,10 @@ struct soc_intel_cannonlake_config {
uint8_t LanWakeFromDeepSx;
uint8_t WolEnableOverride;
+#if !CONFIG(SOC_INTEL_COMETLAKE)
+ uint32_t VrPowerDeliveryDesign;
+#endif
+
/*
* Override GPIO PM configuration:
* 0: Use FSP default GPIO PM program,
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index b432087a32..b7e9ad8d8b 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -459,6 +459,10 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
#endif
}
+#if !CONFIG(SOC_INTEL_COMETLAKE)
+ params->VrPowerDeliveryDesign = config->VrPowerDeliveryDesign;
+#endif
+
dev = pcidev_path_on_root(SA_DEVFN_IGD);
if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled)
params->PeiGraphicsPeimInit = 1;