summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-03-02 01:48:56 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-03-06 17:32:54 +0000
commitd3b4de7bea6aafa351a60aa8070af577fe2705eb (patch)
treed1b5c1bf9e72fc5285645b0fcb81ee1f87c1bcc4 /src
parent8247cc3328aef91b4e39b68957acc3dcaebce125 (diff)
drivers/broadcom: Add ASPM blacklist
The Broadcom BCM5751 NIC on a PCIe card will make the computer hang if ASPM gets enabled. Blacklist it. Change-Id: I2cf8d56e9139928a6acfd1d09e47a96b9554fb06 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39193 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/drivers/broadcom/Makefile.inc14
-rw-r--r--src/drivers/broadcom/bcm57xx_aspm_disable.c43
2 files changed, 57 insertions, 0 deletions
diff --git a/src/drivers/broadcom/Makefile.inc b/src/drivers/broadcom/Makefile.inc
new file mode 100644
index 0000000000..88433d291f
--- /dev/null
+++ b/src/drivers/broadcom/Makefile.inc
@@ -0,0 +1,14 @@
+##
+## This file is part of the coreboot project.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+## GNU General Public License for more details.
+##
+
+ramstage-$(CONFIG_PCIEXP_ASPM) += bcm57xx_aspm_disable.c
diff --git a/src/drivers/broadcom/bcm57xx_aspm_disable.c b/src/drivers/broadcom/bcm57xx_aspm_disable.c
new file mode 100644
index 0000000000..427ba623a2
--- /dev/null
+++ b/src/drivers/broadcom/bcm57xx_aspm_disable.c
@@ -0,0 +1,43 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <device/device.h>
+#include <device/pci.h>
+#include <device/pci_ids.h>
+
+static void bcm57xx_disable_aspm(struct device *const dev)
+{
+ printk(BIOS_INFO, "bcm57xx: Disabling ASPM for %s [%04x/%04x]\n",
+ dev_path(dev), dev->vendor, dev->device);
+
+ dev->disable_pcie_aspm = 1;
+}
+
+static struct device_operations bcm57xx_aspm_fixup_ops = {
+ .read_resources = pci_dev_read_resources,
+ .set_resources = pci_dev_set_resources,
+ .enable_resources = pci_dev_enable_resources,
+ .enable = bcm57xx_disable_aspm,
+};
+
+static const unsigned short pci_device_ids[] = {
+ 0x1677, /* BCM5751 */
+ 0,
+};
+
+static const struct pci_driver bcm57xx_aspm_fixup __pci_driver = {
+ .ops = &bcm57xx_aspm_fixup_ops,
+ .vendor = PCI_VENDOR_ID_BROADCOM,
+ .devices = pci_device_ids,
+};