diff options
| author | Werner Zeh <werner.zeh@siemens.com> | 2017-06-30 10:05:06 +0200 |
|---|---|---|
| committer | Werner Zeh <werner.zeh@siemens.com> | 2017-07-02 15:39:00 +0000 |
| commit | 5e21cd450c13176450e817fdf470925d45daaf05 (patch) | |
| tree | 751d6e0168074c19c79f6ec45e45c8733c816650 /src | |
| parent | a1de1a0810892c3c3a22ed6e2868fbef3bde8134 (diff) | |
vendorcode/siemens: Fix bug in hwilib for FF_FanReq and FF_FreezeDis
The two flags FF_FanReq and FF_Freeze_Dis should be treated as
8 bit values and not as 32 bit. Change the length of these fields to
1 byte and adjust the offset and mask for FF_FanReq.
Change-Id: If5e9e8b16491a33997cc39c3dd9b80f97682adc6
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/20431
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/vendorcode/siemens/hwilib/hwilib.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index c1533e80e2..08e8da98ff 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -143,14 +143,14 @@ static const struct param_info params[] = { .pos[0] = {.blk_type = BLK_HIB, .offset = 0xe0, .len = 0x80}, .get_field = hwilib_read_bytes }, [FF_FreezeDis] = { - .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4}, + .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 1}, .mask = 0x10, .mask_offset = 4, .get_field = hwilib_read_bytes }, [FF_FanReq] = { - .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4}, - .mask = 0x400, - .mask_offset = 10, + .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b9, .len = 1}, + .mask = 0x04, + .mask_offset = 2, .get_field = hwilib_read_bytes }, [NvramVirtTimeDsaveReset] = { .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1be, .len = 2}, |