summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-05-06 17:54:04 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-05-16 15:21:39 +0000
commitab660f533f7cb2868764a3ae60a245ab858eb314 (patch)
tree7dbec5224995eb3ee4765fc6a7beacc934086192 /src
parent2ec44ec95fece227b9dbd7bf70e03c2ddcb5e45a (diff)
soc/amd/cezanne/fsp_m_params: add defines for FSP USB struct version
Add and use defines instead of magic values in fsp_m_params.c. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ie0e33eb0af5310ab4610ea8951688464c4960260 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64126 Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/amd/cezanne/fsp_m_params.c4
-rw-r--r--src/vendorcode/amd/fsp/cezanne/FspUsb.h3
2 files changed, 5 insertions, 2 deletions
diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c
index 5b386a5314..cfe934b64b 100644
--- a/src/soc/amd/cezanne/fsp_m_params.c
+++ b/src/soc/amd/cezanne/fsp_m_params.c
@@ -151,8 +151,8 @@ void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
if (config->usb_phy_custom) {
mcfg->usb_phy = (struct usb_phy_config *)&config->usb_phy;
- mcfg->usb_phy->Version_Major = 0xd;
- mcfg->usb_phy->Version_Minor = 0x6;
+ mcfg->usb_phy->Version_Major = FSP_USB_STRUCT_MAJOR_VERSION;
+ mcfg->usb_phy->Version_Minor = FSP_USB_STRUCT_MINOR_VERSION;
mcfg->usb_phy->TableLength = sizeof(struct usb_phy_config);
} else {
mcfg->usb_phy = NULL;
diff --git a/src/vendorcode/amd/fsp/cezanne/FspUsb.h b/src/vendorcode/amd/fsp/cezanne/FspUsb.h
index 6563cacc81..fea1fee3bd 100644
--- a/src/vendorcode/amd/fsp/cezanne/FspUsb.h
+++ b/src/vendorcode/amd/fsp/cezanne/FspUsb.h
@@ -3,6 +3,9 @@
#include <FspUpd.h>
+#define FSP_USB_STRUCT_MAJOR_VERSION 0xd
+#define FSP_USB_STRUCT_MINOR_VERSION 0x6
+
#define USB2_PORT_COUNT 8
#define USB3_PORT_COUNT 4
#define USBC_COMBO_PHY_COUNT 2