diff options
author | Felix Held <felix-coreboot@felixheld.de> | 2024-01-24 21:11:39 +0100 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2024-01-25 22:50:36 +0000 |
commit | 632568732b0f2cd47f87337410ee90899ed298ca (patch) | |
tree | 0ae0373c91772c6d784d8ef32f70d580d3c92345 /src/vendorcode/amd/opensil | |
parent | 4f76170819550bfc52bfbd4de0e755d4ea5e4858 (diff) |
vc/amd/opensil/genoa_poc/opensil_console: fix host debug print function
Since we pass va_list list to the print function, we need to use vprintk
instead of printk. Earlier versions of this code used vsnprintf and a
local buffer, but when that code was reworked to not need the temporary
buffer, it was replaced by printk instead of the correct vprintk.
TEST=Now the console output from openSIL looks as expected:
Example line from openSIL's console output when it prints the MPIO
configuration from a log some commits before this patch:
Host PCI Address - -1352681400:-1353251983:7
Same line with this patch applied looks how it's supposed to:
Host PCI Address - 0:0:0
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: Varshit Pandya <pandyavarshit@gmail.com>
Change-Id: Ia931cc80dea5b7eabb75cfb19f8baa9a09cd2dbf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80203
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/vendorcode/amd/opensil')
-rw-r--r-- | src/vendorcode/amd/opensil/genoa_poc/opensil_console.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c b/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c index 55a352166f..35e5eeb2b4 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c +++ b/src/vendorcode/amd/opensil/genoa_poc/opensil_console.c @@ -39,6 +39,6 @@ void HostDebugService(size_t MsgLevel, const char *SilPrefix, const char *Messag /* print formatted message */ va_list args; va_start(args, Line); - printk(loglevel, Message, args); + vprintk(loglevel, Message, args); va_end(args); } |