summaryrefslogtreecommitdiff
path: root/src/southbridge/via/vt8235
diff options
context:
space:
mode:
authorStefan Reinauer <stepan@coresystems.de>2010-04-07 01:44:04 +0000
committerStefan Reinauer <stepan@openbios.org>2010-04-07 01:44:04 +0000
commitc51dc44bf2b76ac47b83ee76bee3357ce4b173de (patch)
treebd9810f58fb58e10e7a32e1e0299a7ba9ec7a3da /src/southbridge/via/vt8235
parent39162f7b47c9258980e08d05038d79d1ff925372 (diff)
"no warnings day"
last round for today. still warnings - help appreciated. Signed-off-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5363 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/southbridge/via/vt8235')
-rw-r--r--src/southbridge/via/vt8235/vt8235.c6
-rw-r--r--src/southbridge/via/vt8235/vt8235_lpc.c12
-rw-r--r--src/southbridge/via/vt8235/vt8235_usb.c3
3 files changed, 6 insertions, 15 deletions
diff --git a/src/southbridge/via/vt8235/vt8235.c b/src/southbridge/via/vt8235/vt8235.c
index 228da0f948..2687972afa 100644
--- a/src/southbridge/via/vt8235/vt8235.c
+++ b/src/southbridge/via/vt8235/vt8235.c
@@ -10,7 +10,6 @@
/*
* Base VT8235.
*/
-static int enabled = 0;
void hard_reset(void)
{
@@ -53,11 +52,9 @@ void set_led()
static void vt8235_enable(struct device *dev)
{
- struct southbridge_via_vt8235_config *conf = dev->chip_info;
unsigned char regval;
unsigned short vendor,model;
-
vendor = pci_read_config16(dev,0);
model = pci_read_config16(dev,0x2);
@@ -72,7 +69,6 @@ static void vt8235_enable(struct device *dev)
printk(BIOS_DEBUG, "Initialising Devices\n");
-
setup_i8259(); // make sure interupt controller is configured before keyboard init
/* enable RTC and ethernet */
@@ -87,8 +83,6 @@ static void vt8235_enable(struct device *dev)
regval = pci_read_config8(dev, 0x50);
regval &= ~(0x36);
pci_write_config8(dev, 0x50, regval);
-
-
}
struct chip_operations southbridge_via_vt8235_ops = {
diff --git a/src/southbridge/via/vt8235/vt8235_lpc.c b/src/southbridge/via/vt8235/vt8235_lpc.c
index 92ba973661..0746bc9a13 100644
--- a/src/southbridge/via/vt8235/vt8235_lpc.c
+++ b/src/southbridge/via/vt8235/vt8235_lpc.c
@@ -105,9 +105,8 @@ static void pci_routing_fixup(struct device *dev)
* can't figure out how to do !!!!
*/
-void setup_pm(device_t dev)
+static void setup_pm(device_t dev)
{
-
// Set gen config 0
pci_write_config8(dev, 0x80, 0x20);
@@ -216,7 +215,7 @@ static void vt8235_init(struct device *dev)
/* total kludge to get lxb to call our childrens set/enable functions - these are not called unless this
device has a resource to set - so set a dummy one */
-void vt8235_read_resources(device_t dev)
+static void vt8235_read_resources(device_t dev)
{
struct resource *res;
@@ -234,21 +233,20 @@ void vt8235_read_resources(device_t dev)
res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
-void vt8235_set_resources(device_t dev)
+static void vt8235_set_resources(device_t dev)
{
- struct resource *resource;
+ //struct resource *resource;
//resource = find_resource(dev,1);
//resource->flags |= IORESOURCE_STORED;
pci_dev_set_resources(dev);
}
-void vt8235_enable_resources(device_t dev)
+static void vt8235_enable_resources(device_t dev)
{
/* vt8235 is not a pci bridge and has no resources of its own (other than standard PC i/o addresses)
however it does control the isa bus and so we need to manually call enable childrens resources on that bus */
pci_dev_enable_resources(dev);
enable_childrens_resources(dev);
-
}
static void southbridge_init(struct device *dev)
diff --git a/src/southbridge/via/vt8235/vt8235_usb.c b/src/southbridge/via/vt8235/vt8235_usb.c
index 8b2a685807..c712136c72 100644
--- a/src/southbridge/via/vt8235/vt8235_usb.c
+++ b/src/southbridge/via/vt8235/vt8235_usb.c
@@ -27,7 +27,6 @@ static void usb_init(struct device *dev)
*/
}
-/*
static struct device_operations usb_ops = {
.read_resources = pci_dev_read_resources,
.set_resources = pci_dev_set_resources,
@@ -42,4 +41,4 @@ static const struct pci_driver northbridge_driver __pci_driver = {
.vendor = PCI_VENDOR_ID_VIA,
.device = PCI_DEVICE_ID_VIA_82C586_2,
};
-*/
+