summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-06-23 12:32:59 +0200
committerPatrick Georgi <pgeorgi@google.com>2021-06-25 06:28:11 +0000
commitadeac8d4f76c8ac33ee56613c79b746547dd12a6 (patch)
tree9afd7b86b6eaa119ffbfcaf83bc8cf6c4c2d4158 /src/soc
parent6464c2aa4f52a15e06c50254f83e622614c06a45 (diff)
soc/intel/apollolake: Drop `xdci_can_enable()` call
The `xdci_can_enable()` function is called earlier to configure FSP-S UPDs. If it returned false, then the xDCI device will be disabled and the second `xdci_can_enable()` call will never be evaluated. Change-Id: I4bd08e3194ffccc79c8feaf8f34b2bb4077f760a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55789 Reviewed-by: Subrata Banik <subrata.banik@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/apollolake/xdci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/xdci.c b/src/soc/intel/apollolake/xdci.c
index 8c86e442ec..5903e34bcc 100644
--- a/src/soc/intel/apollolake/xdci.c
+++ b/src/soc/intel/apollolake/xdci.c
@@ -40,7 +40,7 @@ static void configure_host_mode_port0(struct device *dev)
* enabled. If it's disabled assume the switch was already done
* in FSP.
*/
- if (!dev->enabled || !xdci_can_enable())
+ if (!dev->enabled)
return;
printk(BIOS_INFO, "Putting port 0 into host mode.\n");