summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2024-08-31 07:29:00 +0200
committerElyes Haouas <ehaouas@noos.fr>2024-09-04 01:16:40 +0000
commit2f8b77b76bdbb6e93f1a9ca3c73f9bb38ec55b41 (patch)
tree862af999e15ccf9df92701e3d007e2e902132ba7 /src/soc
parent37c85f0cf54c992d283b5f306ce43b9522c515f2 (diff)
tree: Drop unnecessary "true/false" comments
Change-Id: I5cd04972936c14d92295915fad65c7a45a8108d9 Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84152 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jakub Czapiga <czapiga@google.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/intel/alderlake/chip.h4
-rw-r--r--src/soc/intel/cannonlake/chip.h3
-rw-r--r--src/soc/intel/common/block/include/intelblocks/uart.h11
-rw-r--r--src/soc/intel/elkhartlake/chip.h1
-rw-r--r--src/soc/intel/jasperlake/chip.h22
-rw-r--r--src/soc/intel/meteorlake/chip.h4
-rw-r--r--src/soc/intel/tigerlake/chip.h23
7 files changed, 6 insertions, 62 deletions
diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h
index ec6c0f5483..c8005dea2c 100644
--- a/src/soc/intel/alderlake/chip.h
+++ b/src/soc/intel/alderlake/chip.h
@@ -466,11 +466,7 @@ struct soc_intel_alderlake_config {
} igd_dvmt50_pre_alloc;
bool skip_ext_gfx_scan;
-
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
-
- /* Enable C6 DRAM */
bool enable_c6dram;
/*
diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 97657e2feb..9459b88808 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -237,10 +237,7 @@ struct soc_intel_cannonlake_config {
/* Enables support for Teton Glacier hybrid storage device */
bool TetonGlacierMode;
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
-
- /* Enable C6 DRAM */
bool enable_c6dram;
/*
diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h
index f140fc87fd..dc27d518aa 100644
--- a/src/soc/intel/common/block/include/intelblocks/uart.h
+++ b/src/soc/intel/common/block/include/intelblocks/uart.h
@@ -14,21 +14,10 @@
* 3. SOC will allow common code to set UART into legacy mode if supported.
*/
-/*
- * Check if UART debug controller is initialized
- * Returns:
- * true = If debug controller PCI config space is initialized and device is
- * out of reset
- * false = otherwise
- */
bool uart_is_controller_initialized(void);
/*
* Check if dev corresponds to UART debug port controller.
- *
- * Returns:
- * true: UART dev is debug port
- * false: otherwise
*/
bool uart_is_debug_controller(struct device *dev);
diff --git a/src/soc/intel/elkhartlake/chip.h b/src/soc/intel/elkhartlake/chip.h
index d446ef0ffa..e3a23b2af3 100644
--- a/src/soc/intel/elkhartlake/chip.h
+++ b/src/soc/intel/elkhartlake/chip.h
@@ -258,7 +258,6 @@ struct soc_intel_elkhartlake_config {
uint8_t Heci2Enable;
uint8_t Heci3Enable;
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
/*
diff --git a/src/soc/intel/jasperlake/chip.h b/src/soc/intel/jasperlake/chip.h
index 542ccb61cb..53bf34f0bf 100644
--- a/src/soc/intel/jasperlake/chip.h
+++ b/src/soc/intel/jasperlake/chip.h
@@ -108,11 +108,7 @@ struct soc_intel_jasperlake_config {
SaGv_Enabled,
} SaGv;
- /* Rank Margin Tool
- *
- * true: Enable
- * false: Disable
- */
+ /* Rank Margin Tool */
bool RMT;
/* USB related */
@@ -178,7 +174,6 @@ struct soc_intel_jasperlake_config {
/* Gfx related */
bool SkipExtGfxScan;
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
/* Enable C6 DRAM */
@@ -263,10 +258,8 @@ struct soc_intel_jasperlake_config {
uint8_t DdiPortAConfig;
uint8_t DdiPortBConfig;
- /* HDP config
- *
- * true: Enable HDB
- * false: Disable HDP
+ /*
+ * HDP config
*/
bool DdiPortAHpd;
bool DdiPortBHpd;
@@ -276,10 +269,8 @@ struct soc_intel_jasperlake_config {
bool DdiPort3Hpd;
bool DdiPort4Hpd;
- /* DDC config
- *
- * true: Enable DDC
- * false: Disable DDC
+ /*
+ * DDC config
*/
bool DdiPortADdc;
bool DdiPortBDdc;
@@ -411,9 +402,6 @@ struct soc_intel_jasperlake_config {
/*
* Enable or Disable Acoustic Noise Mitigation feature.
- *
- * false: Disabled
- * true: Enabled
*/
bool AcousticNoiseMitigation;
diff --git a/src/soc/intel/meteorlake/chip.h b/src/soc/intel/meteorlake/chip.h
index e76f169ca9..bf7bd36753 100644
--- a/src/soc/intel/meteorlake/chip.h
+++ b/src/soc/intel/meteorlake/chip.h
@@ -209,7 +209,7 @@ struct soc_intel_meteorlake_config {
SAGV_POINTS_0_1_2_3 = 0x0f,
} sagv_wp_bitmap;
- /* Rank Margin Tool. true:Enable, false:Disable */
+ /* Rank Margin Tool. */
bool rmt;
/* USB related */
@@ -297,8 +297,6 @@ struct soc_intel_meteorlake_config {
} igd_dvmt50_pre_alloc;
bool skip_ext_gfx_scan;
-
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
/*
diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h
index 6785ebaaeb..6f0adcc6d0 100644
--- a/src/soc/intel/tigerlake/chip.h
+++ b/src/soc/intel/tigerlake/chip.h
@@ -285,8 +285,6 @@ struct soc_intel_tigerlake_config {
/* Gfx related */
uint8_t SkipExtGfxScan;
-
- /* Enable/Disable EIST. true:Enabled, false:Disabled */
bool eist_enable;
/* Enable C6 DRAM */
@@ -504,29 +502,8 @@ struct soc_intel_tigerlake_config {
* - PM_CFG.SLP_LAN_MIN_ASST_WDTH
*/
uint8_t PchPmPwrCycDur;
-
- /*
- * External Clock Gate
- * true = Mainboard design uses external clock gating
- * false = Mainboard design does not use external clock gating
- *
- */
bool external_clk_gated;
-
- /*
- * External PHY Gate
- * true = Mainboard design uses external phy gating
- * false = Mainboard design does not use external phy gating
- *
- */
bool external_phy_gated;
-
- /*
- * External Bypass Enable
- * true = Mainboard design uses external bypass rail
- * false = Mainboard design does not use external bypass rail
- *
- */
bool external_bypass;
/* i915 struct for GMA backlight control */