diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2024-01-26 21:54:51 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-01-28 14:01:04 +0000 |
| commit | e4e26560ee70d4215cbfb5f24cbbc9283177c4d9 (patch) | |
| tree | 314aee8db70180ee23fa4dfa518ff5d49ce240e0 /src/soc | |
| parent | 112c2277f51684157f5c46a06b3b038b5b730679 (diff) | |
soc/amd/*/acpi: drop CRAT TODO
The CRAT (Component Resource Attribute Table) isn't used on the APUs
from Renoir on and has also been marked as deprecated in version 6.5 of
the ACPI specification. So remove the 'TODO: look into adding CRAT'
comment from all SoCs from Renoir/Cezanne on.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I3ea1e3678608b0ace2a1ff7fc104594e90c91476
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80227
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc')
| -rw-r--r-- | src/soc/amd/cezanne/acpi.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/glinda/acpi.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/mendocino/acpi.c | 2 | ||||
| -rw-r--r-- | src/soc/amd/phoenix/acpi.c | 2 |
4 files changed, 0 insertions, 8 deletions
diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c index c99159a866..f60512d069 100644 --- a/src/soc/amd/cezanne/acpi.c +++ b/src/soc/amd/cezanne/acpi.c @@ -58,8 +58,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) { - /* TODO: look into adding CRAT */ - /* IVRS */ current = acpi_add_ivrs_table(current, rsdp); diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c index 8b6031c2b1..eb1d4782a1 100644 --- a/src/soc/amd/glinda/acpi.c +++ b/src/soc/amd/glinda/acpi.c @@ -61,8 +61,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) { - /* TODO: look into adding CRAT */ - /* IVRS */ current = acpi_add_ivrs_table(current, rsdp); diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c index 898e75eef5..e7f0d96c64 100644 --- a/src/soc/amd/mendocino/acpi.c +++ b/src/soc/amd/mendocino/acpi.c @@ -60,8 +60,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) { - /* TODO: look into adding CRAT */ - /* IVRS */ current = acpi_add_ivrs_table(current, rsdp); diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index a8be10e986..a6482ee67d 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -61,8 +61,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) { - /* TODO: look into adding CRAT */ - /* IVRS */ current = acpi_add_ivrs_table(current, rsdp); |