summaryrefslogtreecommitdiff
path: root/src/soc/intel
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2024-07-17 12:22:43 +0200
committerFelix Held <felix-coreboot@felixheld.de>2024-08-11 17:10:08 +0000
commit96719adda3f5e96cc5af537f3d9c70ae75073b46 (patch)
tree6fc7ab1279509dae46eca94cbe38c62d3dc1d24b /src/soc/intel
parentaf0d4bce65df277b56e495892dff1c712ed76ddd (diff)
azalia: Get rid of "return {-1,0}
Use 'enum cb_err' instead of {-1,0}. Change-Id: Icea33ea3e6a5e3c7bbfedc29045026cd722ac23e Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83503 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin L Roth <gaumless@gmail.com>
Diffstat (limited to 'src/soc/intel')
-rw-r--r--src/soc/intel/common/hda_verb.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/intel/common/hda_verb.c b/src/soc/intel/common/hda_verb.c
index dceb03183e..67a8f24516 100644
--- a/src/soc/intel/common/hda_verb.c
+++ b/src/soc/intel/common/hda_verb.c
@@ -4,7 +4,7 @@
#include <delay.h>
#include <device/azalia_device.h>
#include <device/mmio.h>
-#include <stdint.h>
+#include <types.h>
#include "hda_verb.h"
@@ -13,7 +13,7 @@ int hda_codec_detect(u8 *base)
u8 reg8;
/* Set Bit 0 to 1 to exit reset state (BAR + 0x8)[0] */
- if (azalia_exit_reset(base) < 0)
+ if (azalia_exit_reset(base) != CB_SUCCESS)
goto no_codec;
/* Write back the value once reset bit is set. */
@@ -26,11 +26,11 @@ int hda_codec_detect(u8 *base)
write8(base + HDA_STATESTS_REG, 0xf);
/* Turn off the link and poll RESET# bit until it reads back as 0 */
- if (azalia_enter_reset(base) < 0)
+ if (azalia_enter_reset(base) != CB_SUCCESS)
goto no_codec;
/* Turn on the link and poll RESET# bit until it reads back as 1 */
- if (azalia_exit_reset(base) < 0)
+ if (azalia_exit_reset(base) != CB_SUCCESS)
goto no_codec;
/* Read in Codec location (BAR + 0xe)[2..0] */