diff options
author | Barnali Sarkar <barnali.sarkar@intel.com> | 2017-07-19 16:27:23 +0530 |
---|---|---|
committer | Aaron Durbin <adurbin@chromium.org> | 2017-07-25 14:58:49 +0000 |
commit | 4859ce0b815e64e8fbe2cea9407eed83a77a7c6d (patch) | |
tree | c19d317487cd68a3e1afb4bee4660305adcc984d /src/soc/intel/skylake/sd.c | |
parent | 50987a7b9e08139829da84958deea7f8bde3d376 (diff) |
soc/intel/skylake: Skip Spi Flash Lockdown from FSP
coreboot was setting SPI FPR register to protect the
mrc_cache data range stored in flash. This programming was being done
after FSP Notify 1.
But, FSP was locking the SPI by setting FLOCKDN Bit during Notify
phase 1, due to which coreboot was unable to protect that range.
As solution, FSP introduced a new UPD SpiFlashCfgLockDown to skip
the lockdown of flash on interest of bootloader. Set that UPD to 0
to skip the lockdown of FAST_SPI flash from FSP.
The same is being done from coreboot after end of Post at finalize.c
file.
BUG=b:63049493
BRANCH=none
TEST=FPR can be set properly to protect the mrc_cache range. The
issue reported in the bug doesn't come when both software and
hardware WP is enabled with this patch.
Change-Id: I3ffca2f1b05ab2e4ef631275ef7c3a6e23e393aa
Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Reviewed-on: https://review.coreboot.org/20645
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/skylake/sd.c')
0 files changed, 0 insertions, 0 deletions