diff options
| author | Keith Hui <buurin@gmail.com> | 2023-03-20 02:03:47 -0400 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-23 15:14:45 +0000 |
| commit | c5d6af43fb544423fa103f523ac85356b3ff3725 (patch) | |
| tree | 8cf30f87ba30b1e3334b4546dddd69dbd8b2ffdd /src/northbridge | |
| parent | 0e1be046acaf5cfb9e2c41521270d137fa3423c5 (diff) | |
nb/intel/snb: Abolish mainboard_should_reset_usb()
Of the 13 mainboards that implement mainboard_should_reset_usb() hook,
all but one do the same: Stop MRC from resetting USB when resuming
from S3 suspend.
This hook turns out is only here to facilitate a USB reset workaround
on samsung/stumpy for an old ChromeOS kernel which is no longer needed.
Drop the workaround, the hook, and headers no longer used.
roda/rv11/early_init.c is left with no useful code after this patch,
so drop it entirely from both bootblock and romstage.
Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/intel/sandybridge/raminit_mrc.c | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/sandybridge/sandybridge.h | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index aec300b5ef..a2a44c422e 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -328,7 +328,7 @@ void perform_raminit(int s3resume) struct mrc_var_data *mrc_var; /* Prepare USB controller early in S3 resume */ - if (!mainboard_should_reset_usb(s3resume)) + if (s3resume) enable_usb_bar(); memset(&pei_data, 0, sizeof(pei_data)); diff --git a/src/northbridge/intel/sandybridge/sandybridge.h b/src/northbridge/intel/sandybridge/sandybridge.h index 1e8786410d..0eaa4ec340 100644 --- a/src/northbridge/intel/sandybridge/sandybridge.h +++ b/src/northbridge/intel/sandybridge/sandybridge.h @@ -65,7 +65,6 @@ void early_init_dmi(void); /* mainboard_early_init: Optional callback, run after console init but before raminit. */ void mainboard_early_init(int s3resume); -int mainboard_should_reset_usb(int s3resume); void perform_raminit(int s3resume); void report_memory_config(void); enum platform_type get_platform_type(void); |