diff options
| author | Michael Niewöhner <foss@mniewoehner.de> | 2020-12-12 01:51:41 +0100 |
|---|---|---|
| committer | Michael Niewöhner <foss@mniewoehner.de> | 2020-12-20 00:02:09 +0000 |
| commit | ccceb2250eeb820fccfb62d1f3ab407582d2e79f (patch) | |
| tree | eca456b4eeaf585d22c9a00cf1af32afa6ff6112 /src/mainboard | |
| parent | 1a0071c7115819302c7df3fa2c07b1ca971e515d (diff) | |
mb/clevo/kbl-u: drop duplicated configuration of UART pads
UART pads already get configured in bootblock by the UART driver in soc
code. Thus, drop the duplicated code from the mainboard.
Change-Id: I95565a74e19d693a7d5ead81e72592cc4ca2038c
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48594
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/clevo/kbl-u/Makefile.inc | 3 | ||||
| -rw-r--r-- | src/mainboard/clevo/kbl-u/bootblock.c | 9 | ||||
| -rw-r--r-- | src/mainboard/clevo/kbl-u/include/variant/gpio.h | 1 | ||||
| -rw-r--r-- | src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c | 17 |
4 files changed, 0 insertions, 30 deletions
diff --git a/src/mainboard/clevo/kbl-u/Makefile.inc b/src/mainboard/clevo/kbl-u/Makefile.inc index b424d4da19..aeb584438b 100644 --- a/src/mainboard/clevo/kbl-u/Makefile.inc +++ b/src/mainboard/clevo/kbl-u/Makefile.inc @@ -2,9 +2,6 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include -bootblock-y += bootblock.c -bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c - ramstage-y += ramstage.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c diff --git a/src/mainboard/clevo/kbl-u/bootblock.c b/src/mainboard/clevo/kbl-u/bootblock.c deleted file mode 100644 index b351fbd8ef..0000000000 --- a/src/mainboard/clevo/kbl-u/bootblock.c +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <bootblock_common.h> -#include <variant/gpio.h> - -void bootblock_mainboard_early_init(void) -{ - variant_configure_early_gpios(); -} diff --git a/src/mainboard/clevo/kbl-u/include/variant/gpio.h b/src/mainboard/clevo/kbl-u/include/variant/gpio.h index 95d576294f..4258325cf9 100644 --- a/src/mainboard/clevo/kbl-u/include/variant/gpio.h +++ b/src/mainboard/clevo/kbl-u/include/variant/gpio.h @@ -3,7 +3,6 @@ #ifndef VARIANT_GPIO_H #define VARIANT_GPIO_H -void variant_configure_early_gpios(void); void variant_configure_gpios(void); #endif diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c b/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c deleted file mode 100644 index dc55aae6d3..0000000000 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c +++ /dev/null @@ -1,17 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <soc/gpio.h> -#include <variant/gpio.h> - -static const struct pad_config early_gpio_table[] = { - // UART2_RXD - _PAD_CFG_STRUCT(GPP_C20, 0x44000702, 0x0), - - // UART2_TXD - _PAD_CFG_STRUCT(GPP_C21, 0x44000700, 0x0) -}; - -void variant_configure_early_gpios(void) -{ - gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table)); -} |