summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorReka Norman <rekanorman@google.com>2022-12-02 16:53:45 +1100
committerEric Lai <eric_lai@quanta.corp-partner.google.com>2023-01-11 00:33:54 +0000
commit72fb5a915a77000b46f7b17a607a5a1b1812d32c (patch)
tree4a9ea0915cd3d52e6352151109cb19fababa6623 /src/mainboard
parent2475e022e2e7e756652da9db8c245370864af4ef (diff)
mb/google/nissa/var/yaviks: Disable storage devices based on fw_config
Disable devices in variant.c instead of adding probe statements to devicetree because storage devices need to be enabled when fw_config is unprovisioned, and devicetree does not currently support this (it disables all probed devices when fw_config is unprovisioned). BUG=b:251055188 TEST=Boot to OS on yaviks eMMC and UFS SKUs with both unprovisioned fw_config and fw_config set correctly. On UFS SKU with fw_config set, eMMC no longer shows up in lspci. (On eMMC SKU, UFS and ISH were already disabled by the coreboot PCI scan so there's no change in behaviour.) Change-Id: I31402cb49cffefd98b6fed971f249528448b1d0d Signed-off-by: Reka Norman <rekanorman@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71725 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Kangheui Won <khwon@chromium.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/brya/variants/yaviks/Makefile.inc1
-rw-r--r--src/mainboard/google/brya/variants/yaviks/fw_config.c42
-rw-r--r--src/mainboard/google/brya/variants/yaviks/variant.c24
3 files changed, 67 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/yaviks/Makefile.inc b/src/mainboard/google/brya/variants/yaviks/Makefile.inc
index 06e2f8dfbf..86ba20d3c3 100644
--- a/src/mainboard/google/brya/variants/yaviks/Makefile.inc
+++ b/src/mainboard/google/brya/variants/yaviks/Makefile.inc
@@ -3,5 +3,6 @@ bootblock-y += gpio.c
romstage-y += gpio.c
+ramstage-$(CONFIG_FW_CONFIG) += fw_config.c
ramstage-$(CONFIG_FW_CONFIG) += variant.c
ramstage-y += gpio.c
diff --git a/src/mainboard/google/brya/variants/yaviks/fw_config.c b/src/mainboard/google/brya/variants/yaviks/fw_config.c
new file mode 100644
index 0000000000..800fc1f205
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yaviks/fw_config.c
@@ -0,0 +1,42 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+#include <console/console.h>
+#include <fw_config.h>
+
+static const struct pad_config emmc_disable_pads[] = {
+ /* I7 : EMMC_CMD */
+ PAD_NC(GPP_I7, NONE),
+ /* I8 : EMMC_D0 */
+ PAD_NC(GPP_I8, NONE),
+ /* I9 : EMMC_D1 */
+ PAD_NC(GPP_I9, NONE),
+ /* I10 : EMMC_D2 */
+ PAD_NC(GPP_I10, NONE),
+ /* I11 : EMMC_D3 */
+ PAD_NC(GPP_I11, NONE),
+ /* I12 : EMMC_D4 */
+ PAD_NC(GPP_I12, NONE),
+ /* I13 : EMMC_D5 */
+ PAD_NC(GPP_I13, NONE),
+ /* I14 : EMMC_D6 */
+ PAD_NC(GPP_I14, NONE),
+ /* I15 : EMMC_D7 */
+ PAD_NC(GPP_I15, NONE),
+ /* I16 : EMMC_RCLK */
+ PAD_NC(GPP_I16, NONE),
+ /* I17 : EMMC_CLK */
+ PAD_NC(GPP_I17, NONE),
+ /* I18 : EMMC_RST_L */
+ PAD_NC(GPP_I18, NONE),
+};
+
+void fw_config_gpio_padbased_override(struct pad_config *padbased_table)
+{
+ if (fw_config_is_provisioned() && !fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) {
+ printk(BIOS_INFO, "Disable eMMC GPIO pins.\n");
+ gpio_padbased_override(padbased_table, emmc_disable_pads,
+ ARRAY_SIZE(emmc_disable_pads));
+ }
+}
diff --git a/src/mainboard/google/brya/variants/yaviks/variant.c b/src/mainboard/google/brya/variants/yaviks/variant.c
index f05f4f78ce..7010520c18 100644
--- a/src/mainboard/google/brya/variants/yaviks/variant.c
+++ b/src/mainboard/google/brya/variants/yaviks/variant.c
@@ -2,6 +2,7 @@
#include <baseboard/variants.h>
#include <boardid.h>
+#include <device/device.h>
#include <fw_config.h>
#include <sar.h>
@@ -37,3 +38,26 @@ void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
printk(BIOS_INFO, "Configured External FIVR\n");
}
}
+
+void variant_devtree_update(void)
+{
+ struct device *emmc = DEV_PTR(emmc);
+ struct device *ufs = DEV_PTR(ufs);
+ struct device *ish = DEV_PTR(ish);
+
+ if (!fw_config_is_provisioned()) {
+ printk(BIOS_INFO, "fw_config unprovisioned so enable all storage devices\n");
+ return;
+ }
+
+ if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_EMMC))) {
+ printk(BIOS_INFO, "eMMC disabled by fw_config\n");
+ emmc->enabled = 0;
+ }
+
+ if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UFS))) {
+ printk(BIOS_INFO, "UFS disabled by fw_config\n");
+ ufs->enabled = 0;
+ ish->enabled = 0;
+ }
+}