summaryrefslogtreecommitdiff
path: root/src/mainboard/system76/adl
diff options
context:
space:
mode:
authorTim Crawford <tcrawford@system76.com>2024-02-27 09:58:05 -0700
committerFelix Held <felix-coreboot@felixheld.de>2024-03-04 14:53:42 +0000
commita78388508c91a82a037efe39f69b3f7d0d8713c5 (patch)
treeac66e735ee0227e51e6b7a743ed8decff532215a /src/mainboard/system76/adl
parentdaa4fb2ca2cab566e6a1c01f6edda65b34e2d4b9 (diff)
mb/system76/adl: Remove duplicate PchHdaAudioLinkHdaEnable
This UPD is hooked up in devicetree since commit 854bd492fcfa ("mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree"). As these boards were in development when the change happened, they still had the UPD set via romstage. Remove them now so they are only set in devicetree. Change-Id: I393e2c7b0134a31feae20f8992d7fd447ff7ee59 Signed-off-by: Tim Crawford <tcrawford@system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80755 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jeremy Soller <jeremy@system76.com>
Diffstat (limited to 'src/mainboard/system76/adl')
-rw-r--r--src/mainboard/system76/adl/variants/lemp11/romstage.c1
-rw-r--r--src/mainboard/system76/adl/variants/oryp10/romstage.c1
-rw-r--r--src/mainboard/system76/adl/variants/oryp9/romstage.c1
3 files changed, 0 insertions, 3 deletions
diff --git a/src/mainboard/system76/adl/variants/lemp11/romstage.c b/src/mainboard/system76/adl/variants/lemp11/romstage.c
index 989b5dff8f..211ab97d20 100644
--- a/src/mainboard/system76/adl/variants/lemp11/romstage.c
+++ b/src/mainboard/system76/adl/variants/lemp11/romstage.c
@@ -15,7 +15,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
};
const bool half_populated = false;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
diff --git a/src/mainboard/system76/adl/variants/oryp10/romstage.c b/src/mainboard/system76/adl/variants/oryp10/romstage.c
index 48714e0c85..86ecf32826 100644
--- a/src/mainboard/system76/adl/variants/oryp10/romstage.c
+++ b/src/mainboard/system76/adl/variants/oryp10/romstage.c
@@ -23,7 +23,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;
diff --git a/src/mainboard/system76/adl/variants/oryp9/romstage.c b/src/mainboard/system76/adl/variants/oryp9/romstage.c
index d16b4f8b03..5e6cf7dd52 100644
--- a/src/mainboard/system76/adl/variants/oryp9/romstage.c
+++ b/src/mainboard/system76/adl/variants/oryp9/romstage.c
@@ -20,7 +20,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0;
- mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0;