diff options
author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 13:02:32 -0800 |
---|---|---|
committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-01-06 20:16:47 +0100 |
commit | 069f4766a013929fa7570194925978b55b8253df (patch) | |
tree | 1b24e081953009c0899ce1fb515a43d3aa402600 /src/mainboard/lippert/frontrunner/romstage.c | |
parent | 5491ca23fc2a0dc69ab6efe149050463207462b8 (diff) |
mainboard: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the mainboard code to use printk() on all non-ROMCC
boards.
Change-Id: I2383f24343fc2041fef4af65d717d754ad58425e
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8111
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/mainboard/lippert/frontrunner/romstage.c')
-rw-r--r-- | src/mainboard/lippert/frontrunner/romstage.c | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/src/mainboard/lippert/frontrunner/romstage.c b/src/mainboard/lippert/frontrunner/romstage.c index f86d5580b5..1f33423ab0 100644 --- a/src/mainboard/lippert/frontrunner/romstage.c +++ b/src/mainboard/lippert/frontrunner/romstage.c @@ -52,9 +52,8 @@ static inline int spd_read_byte(unsigned int device, unsigned int address) #if CONFIG_DEBUG_SMBUS if (address >= sizeof(spdbytes) || spdbytes[address] == 0xFF) { - print_err("ERROR: spd_read_byte(DIMM0, 0x"); - print_err_hex8(address); - print_err(") returns 0xff\n"); + printk(BIOS_ERR, "ERROR: spd_read_byte(DIMM0, 0x%02x) " + "returns 0xff\n", address); } #endif @@ -85,29 +84,29 @@ void main(unsigned long bist) console_init(); cs5535_early_setup(); - print_err("done cs5535 early\n"); + printk(BIOS_ERR, "done cs5535 early\n"); /* Halt if there was a built in self test failure */ report_bist_failure(bist); pll_reset(); - print_err("done pll_reset\n"); + printk(BIOS_ERR, "done pll_reset\n"); cpuRegInit(); - print_err("done cpuRegInit\n"); + printk(BIOS_ERR, "done cpuRegInit\n"); sdram_initialize(1, memctrl); - print_err("Done sdram_initialize\n"); - print_err("Disable watchdog\n"); + printk(BIOS_ERR, "Done sdram_initialize\n"); + printk(BIOS_ERR, "Disable watchdog\n"); outb( 0x87, 0x4E); //enter SuperIO configuration mode outb( 0x87, 0x4E); outb(0x20, 0x4e); temp = inb(0x4f); - print_debug_hex8(temp); + printk(BIOS_DEBUG, "%02x", temp); if (temp != 0x52){ - print_err("CAN NOT READ SUPERIO VID\n"); + printk(BIOS_ERR, "CAN NOT READ SUPERIO VID\n"); } outb(0x29, 0x4e); @@ -121,9 +120,9 @@ void main(unsigned long bist) outb( 0xC7, 0x4F); outb( 0xF1, 0x4E); //clr GP33 (Bit4) value in cofiguration register F1h to \u20181\u2019 disables temp = inb(0x4F); //watchdog function. Make sure to let the other Bits unchanged! - print_debug_hex8(temp);print_debug(":"); + printk(BIOS_DEBUG, "%02x:", temp); temp = temp & ~8; outb( temp, 0x4F); temp = inb(0x4F); //watchdog function. Make sure to let the other Bits unchanged! - print_debug_hex8(temp);print_debug("\n"); + printk(BIOS_DEBUG, "%02x\n", temp); } |