summaryrefslogtreecommitdiff
path: root/src/mainboard/intel/shadowmountain
diff options
context:
space:
mode:
authorMAULIK V VAGHELA <maulik.v.vaghela@intel.com>2022-03-07 18:39:17 +0530
committerNick Vaccaro <nvaccaro@google.com>2022-03-15 18:10:41 +0000
commit215a97ee1c4cd87b266d63e32bf0b379e18fe849 (patch)
treec6ef1cae5509d9328198e9b468b55ad3e5d53791 /src/mainboard/intel/shadowmountain
parent6207a3967e0efeb0b52e24bc82b16e53085b6b9b (diff)
soc/intel/adl/chip.h: Convert all camel case variables to snake case
coreboot chip.h files mainly contains variable which allows board to fill platform configuration through devicetree. Since many of this configuration involves FSP UPDs, variable names were in camel case which aligned with UPD naming convention. By default coreboot follow snake case variable naming, so cleaning up file to align all variable names as per coreboot convention. During renaming process, this patch also removes unused variables listed below: -> SataEnable // Checked in SoC code based on PCI dev enabled status -> ITbtConnectTopologyTimeoutInMs // SoC always passes 0, so not used Note: Since separating out changes into smaller CL might break the compilation for the patch set, this is being pushed as a single big CL. BUG=None BRANCH=firmware-brya-14505.B TEST=All boards using ADL SoC compiles with the CL. Change-Id: Ieda567a89ec9287e3d988d489f3b3769dffcf9e0 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62645 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Diffstat (limited to 'src/mainboard/intel/shadowmountain')
-rw-r--r--src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb43
1 files changed, 21 insertions, 22 deletions
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
index 63d3da423b..e68afe24f3 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
@@ -13,14 +13,14 @@ chip soc/intel/alderlake
register "pmc_gpe0_dw2" = "GPP_E"
# TCSS
- register "TcssAuxOri" = "1"
+ register "tcss_aux_ori" = "1"
register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_A5, .pad_auxn_dc = GPP_A6}"
# Enable CNVi Bluetooth
- register "CnviBtCore" = "true"
+ register "cnvi_bt_core" = "true"
# FSP configuration
- register "SaGv" = "SaGv_Enabled"
+ register "sagv" = "SaGv_Enabled"
# S0ix enable
register "s0ix_enable" = "1"
@@ -65,16 +65,15 @@ chip soc/intel/alderlake
}"
# Enable SATA
- register "SataEnable" = "1"
- register "SataMode" = "0"
- register "SataSalpSupport" = "1"
- register "SataPortsEnable[0]" = "0"
- register "SataPortsEnable[1]" = "1"
- register "SataPortsDevSlp[0]" = "0"
- register "SataPortsDevSlp[1]" = "1"
- register "SataPortsEnableDitoConfig[1]" = "1"
+ register "sata_mode" = "0"
+ register "sata_salp_support" = "1"
+ register "sata_ports_enable[0]" = "0"
+ register "sata_ports_enable[1]" = "1"
+ register "sata_ports_dev_slp[0]" = "0"
+ register "sata_ports_dev_slp[1]" = "1"
+ register "sata_ports_enable_dito_config[1]" = "1"
- register "SerialIoI2cMode" = "{
+ register "serial_io_i2c_mode" = "{
[PchSerialIoIndexI2C0] = PchSerialIoPci,
[PchSerialIoIndexI2C1] = PchSerialIoPci,
[PchSerialIoIndexI2C2] = PchSerialIoPci,
@@ -83,36 +82,36 @@ chip soc/intel/alderlake
[PchSerialIoIndexI2C5] = PchSerialIoPci,
}"
- register "SerialIoGSpiMode" = "{
+ register "serial_io_gspi_mode" = "{
[PchSerialIoIndexGSPI0] = PchSerialIoPci,
[PchSerialIoIndexGSPI1] = PchSerialIoDisabled,
[PchSerialIoIndexGSPI2] = PchSerialIoDisabled,
[PchSerialIoIndexGSPI3] = PchSerialIoDisabled,
}"
- register "SerialIoGSpiCsMode" = "{
+ register "serial_io_gspi_cs_mode" = "{
[PchSerialIoIndexGSPI0] = 1,
}"
- register "SerialIoGSpiCsState" = "{
+ register "serial_io_gspi_cs_state" = "{
[PchSerialIoIndexGSPI0] = 1,
}"
- register "SerialIoUartMode" = "{
+ register "serial_io_uart_mode" = "{
[PchSerialIoIndexUART0] = PchSerialIoSkipInit,
[PchSerialIoIndexUART1] = PchSerialIoDisabled,
[PchSerialIoIndexUART2] = PchSerialIoDisabled,
}"
# HD Audio
- register "PchHdaDspEnable" = "1"
- register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T"
- register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ"
- register "PchHdaIDispCodecEnable" = "1"
+ register "pch_hda_dsp_enable" = "1"
+ register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
+ register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
+ register "pch_hda_idisp_codec_enable" = "1"
# DP port
- register "DdiPortAConfig" = "1" # eDP
- register "DdiPortBConfig" = "0"
+ register "ddi_portA_config" = "1" # eDP
+ register "ddi_portB_config" = "0"
# Enable Display Port Configuration
register "ddi_ports_config" = "{