diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-09 21:07:43 -0500 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-19 03:49:48 +0200 |
| commit | fa840676f5f3bd92b63c352f0c8bf6f14bc2c314 (patch) | |
| tree | ba323c7f7691cf5cab2df5b1110711e46ceba652 /src/mainboard/hp | |
| parent | 91b6d3a6b9430c94989d37982a56ead948419e78 (diff) | |
ec/compal/ene932: Update to use coreboot EC-mainboard API
This patch implements a simple interface between the EC and mainboard
ASL code. This interface does not rely on the preprocessor, and
prevents name conflicts by scoping the interface methods. As this
interface is documented on the coreboot wiki, an in-tree documentation
is not provided.
Change-Id: If0b09be4f5e17cc444539a30f0186590fa0b72b5
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/5515
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@gmail.com>
Diffstat (limited to 'src/mainboard/hp')
| -rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl | 4 | ||||
| -rw-r--r-- | src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl | 21 |
2 files changed, 19 insertions, 6 deletions
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl index e0d92fabac..188515c165 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ec.asl @@ -6,9 +6,7 @@ /* * EC bits specific to the mainboard */ -#define EC_SCI 3 -/* TODO: We do not yet know how the LID is connected to the platform */ -#define EC_ACPI_LID_SWITCH_OBJECT Zero +#define EC_SCI_GPE 3 /* ACPI code for EC functions */ #include <ec/compal/ene932/acpi/ec.asl> diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl index e30d083aa8..57e2b3c5c7 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl @@ -38,7 +38,6 @@ /* Variables used by EC */ /* TODO: These may belong in global non-volatile storage */ Name(PWRS, Zero) - Name(LIDS, Zero) /* AcpiGpe0Blk */ OperationRegion(GP0B, SystemMemory, 0xfed80814, 0x04) @@ -78,8 +77,24 @@ Scope (\_SB) { Name(_HID, EisaId("PNP0C0D")) Method(_LID, 0) { - Store (GE22, \LIDS) - Return (\LIDS) + Return (GE22) /* GE pin 22 */ } } + + Device (MB) { + /* Lid open */ + Method (LIDO) { /* Stub */ } + /* Lid closed */ + Method (LIDC) { /* Stub */ } + /* Increase brightness */ + Method (BRTU) { /* Stub */ } + /* Decrease brightness */ + Method (BRTD) { /* Stub */ } + /* Switch display */ + Method (DSPS) { /* Stub */ } + /* Toggle wireless */ + Method (WLTG) { /* Stub */ } + /* Return lid state */ + Method (LIDS) { /* Stub */ } + } } |