diff options
author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2022-09-23 13:36:36 -0500 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-27 15:15:39 +0000 |
commit | 4a16be91dd9bc3acee7af466a79a9fce857560e3 (patch) | |
tree | cf278db731dfaed055bd9fa7007903f3f0cffa3c /src/mainboard/google/zork/variants/baseboard | |
parent | fdcf698a89ebfe2316fc6ef2f94df7c8203a7f4b (diff) |
mb/google/zork: rename baseboard GPIO table getter for clarity
Rename variant_base_gpio_table() to baseboard_gpio_table(), since the
GPIO table comes from the baseboard, and is overridden by a separate
table from the variant.
Drop the __weak qualifier as this function is not overridden.
Change-Id: Iaa3c9404919fd6c43596d7b27cfab43a1a5b0b21
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67808
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/google/zork/variants/baseboard')
3 files changed, 6 insertions, 12 deletions
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c index ffcfb2539a..6dc3595d63 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c @@ -160,8 +160,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = { PAD_GPO(GPIO_144, LOW), }; -const __weak -struct soc_amd_gpio *variant_base_gpio_table(size_t *size) +const struct soc_amd_gpio *baseboard_gpio_table(size_t *size) { *size = ARRAY_SIZE(gpio_set_stage_ram); return gpio_set_stage_ram; diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index ae1252db0b..8d264c8476 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -172,8 +172,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = { PAD_GPO(GPIO_144, LOW), }; -const __weak -struct soc_amd_gpio *variant_base_gpio_table(size_t *size) +const struct soc_amd_gpio *baseboard_gpio_table(size_t *size) { *size = ARRAY_SIZE(gpio_set_stage_ram); return gpio_set_stage_ram; diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index 09d5786b14..11926d102e 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -11,16 +11,12 @@ #include <soc/platform_descriptors.h> const struct soc_amd_gpio *variant_early_gpio_table(size_t *size); -/* - * This function provides base GPIO configuration table. It is typically provided by - * baseboard using a weak implementation. If GPIO configuration for a variant differs - * significantly from the baseboard, then the variant can also provide a strong implementation - * of this function. - */ -const struct soc_amd_gpio *variant_base_gpio_table(size_t *size); + +/* This function provides base GPIO configuration table. */ +const struct soc_amd_gpio *baseboard_gpio_table(size_t *size); /* * This function allows variant to override any GPIOs that are different than the base GPIO - * configuration provided by variant_base_gpio_table(). + * configuration provided by baseboard_gpio_table(). */ const struct soc_amd_gpio *variant_override_gpio_table(size_t *size); |