summaryrefslogtreecommitdiff
path: root/src/mainboard/google/zork/variants/baseboard
diff options
context:
space:
mode:
authorPeter Marheine <pmarheine@chromium.org>2021-08-17 11:06:01 +1000
committerFelix Held <felix-coreboot@felixheld.de>2021-08-20 15:15:26 +0000
commit2c36b1b6675a81213c73d9655211750a6afdeef5 (patch)
tree192944471b62eaeef8311ea3ca385d426a170e27 /src/mainboard/google/zork/variants/baseboard
parentb90e6fdd25f7fcc9db6be50a0b117a7509c6fdb1 (diff)
mb/google/zork: only enable RTD2141 when present
An MST hub is only present on some devices that are configured with a particular daughterboard indicated by EC fw_config, so add a fw_config probe that matches the USB daughterboard ID from CBI to only enable it on devices where present, using variant-specific daughterboard IDs. BUG=b:185862297 TEST=RTD2141 remains in ACPI tables on a berknip with Dali DB, and is not present on the same system if probe is changed to enable it for picasso DB. BRANCH=zork Change-Id: I4ada9b492ab221fa98350bf2faf27a23342f3a55 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56990 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sam McNally <sammc@google.com>
Diffstat (limited to 'src/mainboard/google/zork/variants/baseboard')
-rw-r--r--src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
index 8b1c68a367..a475202888 100644
--- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
+++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb
@@ -1,4 +1,9 @@
# SPDX-License-Identifier: GPL-2.0-or-later
+
+fw_config
+ field USB_DAUGHTERBOARD 0 3 end
+end
+
chip soc/amd/picasso
# Set FADT Configuration
@@ -408,7 +413,8 @@ chip soc/amd/picasso
register "name" = ""MSTH""
register "uid" = "1"
register "desc" = ""Realtek RTD2141B""
- device i2c 4a on end
+ # Device presence is variant-specific
+ device i2c 4a alias db_mst off end
end
end
end