summaryrefslogtreecommitdiff
path: root/src/mainboard/google/glados/variants/caroline
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-02-23 18:39:39 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-03-03 23:30:05 +0000
commitde5d8ba55909b83df89d59aafcf3036723413ae5 (patch)
tree2c058e97162bb5e56780733d1f7bb392a55e95d7 /src/mainboard/google/glados/variants/caroline
parent2d5642c70d8794d2d86b7da77152e3ea871732c9 (diff)
mb/google/glados: Drop TPM PIRQ
The Infineon TPM 1.2 used on glados boards doesn't use a PIRQ; Linux only works with 'tpm.tis_interrupts=0" and Windows fails to init the TPM citing a lack of available resources. With the PIRQ removed, both Linux and Windows are happy / the TPM is available for use. Test: build/boot Linux 5.16.x and Windows 11 on google/chell Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62444 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/google/glados/variants/caroline')
-rw-r--r--src/mainboard/google/glados/variants/caroline/include/variant/gpio.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
index fe31102f64..8003dbeda5 100644
--- a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
@@ -152,7 +152,7 @@ static const struct pad_config gpio_table[] = {
/* TS_SPI1_IO2 */ PAD_NC(GPP_D21, NONE),
/* TS_SPI1_IO3 */ PAD_CFG_GPO(GPP_D22, 1, DEEP), /* I2S2 BUFFER */
/* I2S_MCLK */ PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SATAXPCI0 */ PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST), /* TPM_PIRQ_L */
+/* SPI_TPM_IRQ */ PAD_NC(GPP_E0, NONE),
/* SATAXPCIE1 */ PAD_NC(GPP_E1, NONE),
/* SATAXPCIE2 */ PAD_NC(GPP_E2, NONE),
/* CPU_GP0 */ PAD_NC(GPP_E3, NONE),