diff options
| author | Duncan Laurie <dlaurie@chromium.org> | 2015-09-03 16:19:42 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-09-10 09:48:47 +0000 |
| commit | 44b01fdcd7bbd7e619f496530d3bfbea69f7fce9 (patch) | |
| tree | 732aee3d78a4ac8d51e96795d5578c5580571f3b /src/mainboard/google/glados/spd | |
| parent | e067083d08b391882c7a773d0a70073d28dc17b4 (diff) | |
glados: Misc code cleanups
- romstage.c is using gpio_configure_pads so it should really
include soc/gpio.h instead of relying on it to come from "gpio.h"
- consistent formatting of array initializers in pei_data.c
- remove pei_data->ec_present flag as this is unused in skylake
- fix printk level in spd/spd.c to be BIOS_INFO instead of BIOS_ERR
- clean up acpi_slp_type usage in ec.c, remove unnecessary post
codes, and cleaner console output message.
BUG=chrome-os-partner:40635
BRANCH=none
TEST=emerge-glados coreboot
Change-Id: I0f76a560dc2c4197e66999752c52573ff0278430
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 67c29f900b7709b73bd0d1e0da26f96cca32828b
Original-Change-Id: Ia2a320acf879fa85e9f6b06265cfe38e50e51e46
Original-Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/297744
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/11568
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard/google/glados/spd')
| -rw-r--r-- | src/mainboard/google/glados/spd/spd.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/google/glados/spd/spd.c b/src/mainboard/google/glados/spd/spd.c index fc9cb53b39..0a17d68a47 100644 --- a/src/mainboard/google/glados/spd/spd.c +++ b/src/mainboard/google/glados/spd/spd.c @@ -22,9 +22,11 @@ #include <cbfs.h> #include <console/console.h> #include <gpio.h> -#include <string.h> +#include <soc/gpio.h> #include <soc/pei_data.h> #include <soc/romstage.h> +#include <string.h> + #include "../gpio.h" #include "spd.h" @@ -94,7 +96,7 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) }; spd_index = gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); - printk(BIOS_ERR, "SPD index %d\n", spd_index); + printk(BIOS_INFO, "SPD index %d\n", spd_index); /* Load SPD data from CBFS */ spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD, |