summaryrefslogtreecommitdiff
path: root/src/mainboard/google/brya/variants/yaviks
diff options
context:
space:
mode:
authorReka Norman <rekanorman@google.com>2022-12-12 10:36:19 +1100
committerFelix Held <felix-coreboot@felixheld.de>2022-12-13 14:52:57 +0000
commit4ae5873e7f056d1996b181d72ef50f2972bdccae (patch)
treefbd607977aa377b070384e7d2153393ef3679790 /src/mainboard/google/brya/variants/yaviks
parent6419fbf1939cecfe547f140841452ff93282e1b9 (diff)
mb/google/nissa/var/nivviks,yaviks: Add DmaProperty for ISH
On nissa, the ISH is running closed source firmware, so the ChromeOS security requirements specify it must be behind an IOMMU. Add DmaProperty to the ISH _DSD on nivviks and yaviks. BUG=b:259716145 TEST=Kernel marks ISH (PCI device 12.0) as untrusted, and changes the IOMMU group type to "DMA". Also, device still goes to S0i3. Before: $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/untrusted 0 $ ls /sys/kernel/iommu_groups/5/devices 0000:00:12.0 0000:00:12.7 $ cat /sys/kernel/iommu_groups/5/type DMA-FQ After: $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/untrusted 1 $ ls /sys/kernel/iommu_groups/5/devices 0000:00:12.0 0000:00:12.7 $ cat /sys/kernel/iommu_groups/5/type DMA Change-Id: Iaddb24580bda77df0c70ff58eb098213f8b509ad Signed-off-by: Reka Norman <rekanorman@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70633 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subratabanik@google.com> Reviewed-by: Kangheui Won <khwon@chromium.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Diffstat (limited to 'src/mainboard/google/brya/variants/yaviks')
-rw-r--r--src/mainboard/google/brya/variants/yaviks/overridetree.cb7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
index 6c58e4eb7e..3ad4ff3523 100644
--- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
@@ -212,7 +212,12 @@ chip soc/intel/alderlake
end
end
device ref emmc on end
- device ref ish on end
+ device ref ish on
+ chip drivers/intel/ish
+ register "add_acpi_dma_property" = "true"
+ device generic 0 on end
+ end
+ end
device ref ufs on end
device ref pch_espi on
chip ec/google/chromeec