summaryrefslogtreecommitdiff
path: root/src/mainboard/emulation/qemu-power8/cbmem.c
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-05-09 12:54:52 +0200
committerDavid Hendricks <david.hendricks@gmail.com>2021-08-22 22:14:43 +0000
commit90afa3c28c14de77f94c7f07ca56e611029112b7 (patch)
treedb61eb282df1fb60818af450ce94819ba06713b7 /src/mainboard/emulation/qemu-power8/cbmem.c
parent2dc73aa4a79bbab7493193c6cec3e5c03e540111 (diff)
AGESA f15tn: Drop `IDSOPT_ASSERT_ENABLED`
The `ASSERT` macro is already defined in `src/include/assert.h`, and AGESA's definition is never used. On Asus A88XM-E, toggling the value of the `IDSOPT_ASSERT_ENABLED` macro does not change the resulting binary when using reproducible builds. Attempting to use AGESA's definition of the `ASSERT` macro results in build errors: In file included from src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c:56: src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c: In function 'GetType4Type7Info': src/vendorcode/amd/agesa/f15tn/Include/Ids.h:371:33: error: statement with no effect [-Werror=unused-value] #define ASSERT(conditional) ((conditional) ? 0 : IdsAssert (STOP_CODE)); Given that coreboot's definition of `ASSERT` is more useful, drop AGESA's broken definition and the useless `IDSOPT_ASSERT_ENABLED` macro. Also remove the `IdsAssert` function, as it is no longer used anywhere. Tested with BUILD_TIMELESS=1, Asus A88XM-E remains identical. Change-Id: Ia4e5dbfd3d2e5cec979b8b16fbc11d1ca8a0661e Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/53983 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Diffstat (limited to 'src/mainboard/emulation/qemu-power8/cbmem.c')
0 files changed, 0 insertions, 0 deletions