diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2013-12-26 22:53:52 -0500 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-01-14 08:07:44 +0100 |
| commit | 3dd0e72d3b9ad5fb6593db6c81c9ad712711e330 (patch) | |
| tree | 9098c3c7c0a59fb77758a7b50d2b4b9d715c948b /src/lib | |
| parent | 8e053afa860e254d099b7c2e530cfbbe185ca098 (diff) | |
lib/hexdump: Take const void * and size_t as arguments
Representing a memory location as an unsigned long is specific to
32-bit architectures. It also doesn't make sense to represent a length
assumed to be positive as a signed integer. With this change, it is no
longer necessary to cast a pointer to unsigned long when passing it to
hexdump.
Change-Id: I641777d940ceac6f37c363051f1e9c1b3ec3ed95
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4575
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/hexdump.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index d24ae775e7..82b0a3ba5b 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -28,7 +28,7 @@ static int isprint(int c) return (c >= 32 && c <= 126); } -void hexdump(unsigned long memory, int length) +void hexdump(const void* memory, size_t length) { int i; uint8_t *m; @@ -48,7 +48,7 @@ void hexdump(unsigned long memory, int length) } if (all_zero < 2) { - printk(BIOS_DEBUG, "%08lx:", memory + i); + printk(BIOS_DEBUG, "%p:", memory + i); for (j = 0; j < 16; j++) printk(BIOS_DEBUG, " %02x", m[i+j]); printk(BIOS_DEBUG, " "); |