diff options
author | Furquan Shaikh <furquan@google.com> | 2019-02-25 16:01:25 -0800 |
---|---|---|
committer | Furquan Shaikh <furquan@google.com> | 2019-02-27 03:52:02 +0000 |
commit | ac8c60e011c0c09a1d161f1bbecf01acce43bbbb (patch) | |
tree | 95f66c5fc0f43f90e372fc1e77fa9ed52d934c9f /src/drivers/net | |
parent | b134368942a5c094fa1612a4b39059243f12ae57 (diff) |
soc/intel/cannonlake: Disable ACPI mode as part of pmc_soc_init
PMC initialization on Cannon Lake happens earlier in the boot sequence
than other SoCs because FSP-Silicon init hides PMC from PCI bus. As
ACPI disabling was done as part of PMC init, it was being called
earlier than what other SoCs do. This resulted in a different order of
events for some drivers e.g. ChromeOS EC. In case of ChromeOS EC, it
ended up clearing EC events (which happens as part of ACPI disabling
in SMM) before logging any events of interest that happen during
mainboard initialization.
This change moves the call to disable ACPI to pmc_soc_init just like
other SoCs to keep the order of events more aligned.
BUG=b:126016602
TEST=Verified that EC panic event gets logged to eventlog correctly.
Change-Id: Ib73883424a8dfd315893ca712ca86c7c08cee551
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/31614
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/drivers/net')
0 files changed, 0 insertions, 0 deletions