summaryrefslogtreecommitdiff
path: root/src/console
diff options
context:
space:
mode:
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>2013-11-23 19:22:53 -0600
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-12-02 22:11:20 +0100
commit72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch)
tree0201395e975f173ebc8badcc952598d559e8a745 /src/console
parentbcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff)
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare the returned value against a CB_CMOS_ error code, or against CB_SUCCESS. Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Reviewed-on: http://review.coreboot.org/4266 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/console')
-rw-r--r--src/console/console.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/console/console.c b/src/console/console.c
index 39a30b5280..a31e293af4 100644
--- a/src/console/console.c
+++ b/src/console/console.c
@@ -24,6 +24,7 @@
#ifndef __PRE_RAM__
#include <string.h>
+#include <types.h>
/*
* FIXME: get_option() needs to be abstracted better so that other non-volatile
@@ -33,14 +34,15 @@
#if CONFIG_USE_OPTION_TABLE
#include <pc80/mc146818rtc.h>
#else
-static inline int get_option(void *dest, const char *name) { return -1; }
+static inline enum cb_err get_option(void *dest, const char *name)
+ { return CB_CMOS_OTABLE_DISABLED; }
#endif
/* initialize the console */
void console_init(void)
{
struct console_driver *driver;
- if(get_option(&console_loglevel, "debug_level"))
+ if(get_option(&console_loglevel, "debug_level") != CB_SUCCESS)
console_loglevel=CONFIG_DEFAULT_CONSOLE_LOGLEVEL;
for(driver = console_drivers; driver < econsole_drivers; driver++) {