diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-07-16 13:05:28 +0000 |
|---|---|---|
| committer | Subrata Banik <subratabanik@google.com> | 2024-07-18 06:01:05 +0000 |
| commit | e7c926482dcd2ab83d0686ec1decc72f59dcd1da (patch) | |
| tree | 522c6544d423a73f7ada43d557011b12d028a8a6 | |
| parent | 84c0d95f3f9eb9e9dde319abc2e04b3e344de0ca (diff) | |
soc/intel/meteorlake: Use common CAR API for cache reporting
Replace the SoC-specific `report_cache_info()` function with the
common `car_report_cache_info()` API from `car_lib`. This promotes code
reuse and reduces SoC-specific implementation for cache reporting.
BUG=none
TEST=Builds and boots successfully on google/rex platform.
Change-Id: Id5ffcab54232294ffa101f975d0ec51ac63f1910
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83482
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
| -rw-r--r-- | src/soc/intel/meteorlake/bootblock/report_platform.c | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/src/soc/intel/meteorlake/bootblock/report_platform.c b/src/soc/intel/meteorlake/bootblock/report_platform.c index bc8ae920c1..405698962d 100644 --- a/src/soc/intel/meteorlake/bootblock/report_platform.c +++ b/src/soc/intel/meteorlake/bootblock/report_platform.c @@ -10,6 +10,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <intelblocks/car_lib.h> #include <soc/bootblock.h> #include <soc/pci_devs.h> @@ -71,21 +72,6 @@ static inline uint16_t get_dev_id(pci_devfn_t dev) return pci_read_config16(dev, PCI_DEVICE_ID); } -static void report_cache_info(void) -{ - int cache_level = CACHE_L3; - struct cpu_cache_info info; - - if (!fill_cpu_cache_info(cache_level, &info)) - return; - - printk(BIOS_INFO, "Cache: Level %d: ", cache_level); - printk(BIOS_INFO, "Associativity = %zd Partitions = %zd Line Size = %zd Sets = %zd\n", - info.num_ways, info.physical_partitions, info.line_size, info.num_sets); - - printk(BIOS_INFO, "Cache size = %zu MiB\n", get_cache_size(&info)/MiB); -} - static void report_cpu_info(void) { u32 i, cpu_id, cpu_feature_flag; @@ -117,7 +103,7 @@ static void report_cpu_info(void) "CPU: AES %ssupported, TXT %ssupported, VT %ssupported\n", mode[aes], mode[txt], mode[vt]); - report_cache_info(); + car_report_cache_info(); } static void report_mch_info(void) |