summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2022-03-16 11:20:54 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-03-18 15:10:39 +0000
commit7496392bd914e8aa4029e3410ee2ecd95a93bbe7 (patch)
tree68a747f216ca1f97575369de890f05413097090b
parent1abbb96c36978b5af167c0ed682403a48f32ab05 (diff)
mb/google/skyrim: Enable tis_plat_irq_status
This will fix: > [INFO ] Probing TPM I2C: tis_plat_irq_status() not implemented, wasting 20ms to wait on Cr50! BUG=b:224618411 TEST=Compile skyrim Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I5add694506ad089adcc8961f101bf507bc39a522 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62873 Reviewed-by: Jon Murphy <jpmurphy@google.com> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/Makefile.inc4
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/tpm_tis.c9
3 files changed, 14 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/Makefile.inc b/src/mainboard/google/skyrim/variants/baseboard/Makefile.inc
index dc1c1fe1eb..7706e50527 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/Makefile.inc
+++ b/src/mainboard/google/skyrim/variants/baseboard/Makefile.inc
@@ -1,7 +1,11 @@
bootblock-y += gpio.c
romstage-y += gpio.c
+romstage-y += tpm_tis.c
ramstage-y += gpio.c
+ramstage-y += tpm_tis.c
+
+verstage-y += tpm_tis.c
smm-y += gpio.c
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
index f095651297..204ddf65a2 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c
+++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
@@ -39,7 +39,7 @@ static const struct soc_amd_gpio base_gpio_table[] = {
/* SOC_SAR_INT_L */
PAD_SCI(GPIO_17, PULL_NONE, EDGE_LOW),
/* GSC_SOC_INT_L */
- PAD_GPI(GPIO_18, PULL_NONE),
+ PAD_INT(GPIO_18, PULL_NONE, EDGE_LOW, STATUS_DELIVERY),
/* I2C3_SCL */
PAD_NF(GPIO_19, I2C3_SCL, PULL_NONE),
/* I2C3_SDA */
diff --git a/src/mainboard/google/skyrim/variants/baseboard/tpm_tis.c b/src/mainboard/google/skyrim/variants/baseboard/tpm_tis.c
new file mode 100644
index 0000000000..0102baa8ce
--- /dev/null
+++ b/src/mainboard/google/skyrim/variants/baseboard/tpm_tis.c
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <security/tpm/tis.h>
+#include <soc/gpio.h>
+
+int tis_plat_irq_status(void)
+{
+ return gpio_interrupt_status(GPIO_18);
+}