diff options
| author | Elyes Haouas <ehaouas@noos.fr> | 2022-07-13 17:40:30 +0200 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-07-19 01:48:13 +0000 |
| commit | e83e090b05b6aa0d8c1816e626836f712ecb9490 (patch) | |
| tree | 27f3a22b6565321805a2cd2ee3fcef9a17c10b48 | |
| parent | 6e84c2ca70851ed8a5d66d9f4f705ae1fbb30b48 (diff) | |
lint/checkpatch: Add a check for existence of a commit log
This reduce the difference with linux v5.19-rc7.
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I4e3b98140d900c5717f4badde71c7be88fd1e23a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65835
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>
| -rwxr-xr-x | util/lint/checkpatch.pl | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 7f124525f2..86fc9b25c2 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2454,6 +2454,7 @@ sub process { my $in_commit_log = 0; #Scanning lines before patch my $has_patch_separator = 0; #Found a --- line my $has_commit_log = 0; #Encountered lines before patch + my $commit_log_lines = 0; #Number of commit log lines my $commit_log_possible_stack_dump = 0; my $commit_log_long_line = 0; my $commit_log_has_diff = 0; @@ -2723,6 +2724,18 @@ sub process { $cnt_lines++ if ($realcnt != 0); +# Verify the existence of a commit log if appropriate +# 2 is used because a $signature is counted in $commit_log_lines + if ($in_commit_log) { + if ($line !~ /^\s*$/) { + $commit_log_lines++; #could be a $signature + } + } elsif ($has_commit_log && $commit_log_lines < 2) { + WARN("COMMIT_MESSAGE", + "Missing commit description - Add an appropriate one\n"); + $commit_log_lines = 2; #warn only once + } + # Check if the commit log has what seems like a diff which can confuse patch if ($in_commit_log && !$commit_log_has_diff && (($line =~ m@^\s+diff\b.*a/([\w/]+)@ && |