summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCoolStar <coolstarorganization@gmail.com>2023-02-09 22:44:09 -0800
committerFelix Singer <felixsinger@posteo.net>2023-02-14 05:39:57 +0000
commite145c2fbe2b2b5df46744882446a9d7a1f323cfa (patch)
tree8d7830bdd0ecbd535ad458c3d07beefca3fd2b18
parent487cd399dfa6a2601c540ff443c994f2d077aa91 (diff)
acpi/acpigen_dptf: Add pkg return to dptf_write_power_limits()
The PPCC method should return the package, but is missing the return statement, leading to DPTF/S0ix to not function properly. Add the required return statement. TEST=build/boot Win11 on google/banshee, verify DPTF, S0ix functional. Change-Id: I051db7d69dd6cdfbb07caf649247ee166c1c74ac Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/72921 Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Tim Wawrzynczak <inforichland@gmail.com> Reviewed-by: Felix Singer <felixsinger@posteo.net>
-rw-r--r--src/acpi/acpigen_dptf.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c
index a4b3b09ba1..a458a5599b 100644
--- a/src/acpi/acpigen_dptf.c
+++ b/src/acpi/acpigen_dptf.c
@@ -400,6 +400,8 @@ void dptf_write_power_limits(const struct dptf_power_limits *limits)
dptf_write_scope(DPTF_CPU);
acpigen_write_method("PPCC", 0);
+ acpigen_emit_byte(RETURN_OP);
+
pkg_count = acpigen_write_package(1); /* 1 for the Revision */
acpigen_write_integer(PPCC_REVISION); /* revision */