diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2023-12-21 14:46:48 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-04-12 18:18:40 +0000 |
| commit | d81324eb74d880bcb434a74f337f9b08a0057c2f (patch) | |
| tree | 3c92d7bac00a2b8c6143eff62989ad000fc251ba | |
| parent | 8204dc395e35e604d91884fa71b2e695bfaac72c (diff) | |
nb/intel/sandybridge/raminit: Drop write to BANDTIMERS_SNB
MRC.bin doesn't write BANDTIMERS_SNB register, so drop the
write. The bits written were targeting a reserved range,
so assume it didn't do anything useful.
Tested on Lenovo X220: Still boots and runs fine.
Change-Id: I920aabd60831c791188af976914553787cc0ff18
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79760
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
| -rw-r--r-- | src/northbridge/intel/sandybridge/raminit_common.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index f896541288..d6d545c10e 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2865,7 +2865,6 @@ void final_registers(ramctr_timing *ctrl) mchbar_setbits32(MC_INIT_STATE_G, 1 << 0); mchbar_setbits32(MC_INIT_STATE_G, 1 << 7); - mchbar_write32(BANDTIMERS_SNB, 0xfa); /* Find a populated channel */ FOR_ALL_POPULATED_CHANNELS |