diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-09-18 14:11:53 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-09-30 11:07:11 +0000 |
| commit | ca83dc2309e144b60abed24c9a81927609ffe480 (patch) | |
| tree | 76863ac9dbde59c47af83f06c5a63900bd8bb776 | |
| parent | 6638b40691a9b375abe1f7d05a8755d58d76fc93 (diff) | |
mb/google: Correct number of jacks in hda_verb.c
This corrects the mismatch found in the verb tables of Monroe Chromebase
and Link Chromebook.
The verb data was not aligned to a multiple of 4, therefore an entry was
repeated as padding.
This was found due to the `_Static_assert()` from CB:84360 failing.
TEST=Tested on LINK under Linux and Win11, audio working properly under both.
Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84414
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/beltino/variants/monroe/hda_verb.c | 2 | ||||
| -rw-r--r-- | src/mainboard/google/link/hda_verb.c | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 064bebfeea..3b529e2682 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -6,7 +6,7 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x00000010, // Number of jacks (NID entries) 0x0017ff00, // Function Reset 0x0017ff00, // Double Function Reset diff --git a/src/mainboard/google/link/hda_verb.c b/src/mainboard/google/link/hda_verb.c index 9381b578dc..d3309cd6d7 100644 --- a/src/mainboard/google/link/hda_verb.c +++ b/src/mainboard/google/link/hda_verb.c @@ -6,7 +6,7 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x11020011, // Codec Vendor / Device ID: Creative CA0132 0x10280550, // Subsystem ID - 0x00000014, // Number of jacks + Number of Malcolm setup blocks. + 0x00000015, // Number of jacks + Number of Malcolm setup blocks. /* Malcolm Setup */ @@ -62,6 +62,9 @@ const u32 cim_verb_data[] = { /* Enable and set EAPD pin for headphone jack */ AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ + AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ /* Pin Widget Verb Table */ |