summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-10-28 19:25:53 +0200
committerMartin L Roth <gaumless@gmail.com>2022-10-29 22:49:33 +0000
commit396fb3db74db75d2cace0d9942d9b4ed49a7e497 (patch)
treeec085aef3a57095027ad8accb6d71d9ccab59400
parenta6e60f043bc626eac58074a6b64ef04f00071f96 (diff)
soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device
Don't set bit 2 in _STA in order for Windows not to show a warning about an unknown device in the device manager for this device. Since the _STA object just returns a constant, a name definition can be used instead of a method definition. TEST=The unknown device with device instance path ACPI\AAHB0000\0 disappeared from the device manager in Windows 10 build 19045 on a Mandolin board with a Picasso APU. Just shutting down and then booting it again won't clear some internal state in Windows, so a reboot is needed instead for the change to become visible. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I8cb1712756c3623cc3ea16210af69cde0fa18f62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68961 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
-rw-r--r--src/soc/amd/cezanne/acpi/mmio.asl6
-rw-r--r--src/soc/amd/glinda/acpi/mmio.asl6
-rw-r--r--src/soc/amd/mendocino/acpi/mmio.asl6
-rw-r--r--src/soc/amd/morgana/acpi/mmio.asl6
-rw-r--r--src/soc/amd/picasso/acpi/sb_fch.asl6
-rw-r--r--src/soc/amd/stoneyridge/acpi/sb_fch.asl6
6 files changed, 6 insertions, 30 deletions
diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl
index fa43db00b7..a109f53ff2 100644
--- a/src/soc/amd/cezanne/acpi/mmio.asl
+++ b/src/soc/amd/cezanne/acpi/mmio.asl
@@ -14,11 +14,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)
diff --git a/src/soc/amd/glinda/acpi/mmio.asl b/src/soc/amd/glinda/acpi/mmio.asl
index 05653e5530..07ff7903d5 100644
--- a/src/soc/amd/glinda/acpi/mmio.asl
+++ b/src/soc/amd/glinda/acpi/mmio.asl
@@ -16,11 +16,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)
diff --git a/src/soc/amd/mendocino/acpi/mmio.asl b/src/soc/amd/mendocino/acpi/mmio.asl
index 5544016666..c4acfb12db 100644
--- a/src/soc/amd/mendocino/acpi/mmio.asl
+++ b/src/soc/amd/mendocino/acpi/mmio.asl
@@ -16,11 +16,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)
diff --git a/src/soc/amd/morgana/acpi/mmio.asl b/src/soc/amd/morgana/acpi/mmio.asl
index 51a7cbd41c..f52f0e8a42 100644
--- a/src/soc/amd/morgana/acpi/mmio.asl
+++ b/src/soc/amd/morgana/acpi/mmio.asl
@@ -16,11 +16,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl
index 7ab3b17fcb..d58e044882 100644
--- a/src/soc/amd/picasso/acpi/sb_fch.asl
+++ b/src/soc/amd/picasso/acpi/sb_fch.asl
@@ -14,11 +14,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)
diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
index 212a111f41..d7490d719e 100644
--- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl
+++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl
@@ -12,11 +12,7 @@ Device (AAHB)
{
Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000)
})
-
- Method (_STA, 0x0, NotSerialized)
- {
- Return (0x0F)
- }
+ Name (_STA, 0xb)
}
Device (GPIO)