summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-10-03 14:57:20 -0700
committerFurquan Shaikh <furquan@google.com>2020-10-07 01:16:12 +0000
commit58d39d07a14f4f1e253fc43c36d66c216ce682d1 (patch)
tree27f0a9d9d03bf26a1b5fee37be1438cbef2fc31e
parent7cb103461ad68e2fe1b4d3b3f71e1e140f5507f8 (diff)
drivers/intel/wifi: Drop call to pci_dev_init
`pci_dev_init()` is used to load and run option ROM on VGA class devices (PCI_CLASS_DISPLAY_VGA). WiFi device is not a VGA class device and hence the call to `pci_dev_init()` is not required. This change drops the call to `pci_dev_init()` from `wifi_pci_dev_init()` in Intel WiFi driver. BUG=b:169802515 BRANCH=zork Change-Id: I6588ea0a5c848904088d05fd1cbdf677b2dc8ea9 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46029 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
-rw-r--r--src/drivers/intel/wifi/wifi.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index 0ad0e1c4a1..e117ec0af7 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -63,8 +63,6 @@ static void intel_wifi_fill_ssdt(const struct device *dev)
static void wifi_pci_dev_init(struct device *dev)
{
- pci_dev_init(dev);
-
if (CONFIG(ELOG)) {
uint32_t val;
val = pci_read_config16(dev, PMCS_DR);