diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-03-31 15:14:14 +1100 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-02 01:08:19 +0200 |
| commit | b5a49ad9d782698f1a845953729eb489456d803d (patch) | |
| tree | 696bbd8e6e1dd2db957ee334f3ad3e2f9ff2d09e | |
| parent | 880e5248dc625f00fe3bc83d13b88730020d577a (diff) | |
superio/fintek/f71889: Avoid .c includes
Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage code.
Change-Id: Id8a1a2e8c87add636af1506598c2669d72dc3238
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5437
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
| -rw-r--r-- | src/superio/fintek/f71889/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/superio/fintek/f71889/chip.h | 2 | ||||
| -rw-r--r-- | src/superio/fintek/f71889/early_serial.c | 4 | ||||
| -rw-r--r-- | src/superio/fintek/f71889/f71889.h | 4 |
4 files changed, 7 insertions, 5 deletions
diff --git a/src/superio/fintek/f71889/Makefile.inc b/src/superio/fintek/f71889/Makefile.inc index ef14b74e87..986414080b 100644 --- a/src/superio/fintek/f71889/Makefile.inc +++ b/src/superio/fintek/f71889/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71889) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71889) += superio.c - diff --git a/src/superio/fintek/f71889/chip.h b/src/superio/fintek/f71889/chip.h index 2895efc92e..50312ad2ef 100644 --- a/src/superio/fintek/f71889/chip.h +++ b/src/superio/fintek/f71889/chip.h @@ -29,4 +29,4 @@ struct superio_fintek_f71889_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71889_CHIP_H */ diff --git a/src/superio/fintek/f71889/early_serial.c b/src/superio/fintek/f71889/early_serial.c index 9623cbd2a3..5e11474dd6 100644 --- a/src/superio/fintek/f71889/early_serial.c +++ b/src/superio/fintek/f71889/early_serial.c @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdint.h> #include <arch/io.h> +#include <device/pnp.h> #include "f71889.h" static void pnp_enter_conf_state(device_t dev) @@ -35,7 +35,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71889_enable_serial(device_t dev, u16 iobase) +void f71889_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71889/f71889.h b/src/superio/fintek/f71889/f71889.h index 1b6a369473..6dc43b36a2 100644 --- a/src/superio/fintek/f71889/f71889.h +++ b/src/superio/fintek/f71889/f71889.h @@ -34,4 +34,6 @@ #define F71889_PME 0x0a /* Power Management Events (PME) and ACPI */ #define F71889_VREF 0x0b /* Vref */ -#endif +void f71889_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71889_F71889_H */ |