summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-09-29 14:02:43 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-10-05 16:18:24 +0000
commit8975e7b0256cc60d2a3cd2a701d15c4d9d9a7ea3 (patch)
tree23db410f0c28a80fd89846dc74ee62b5defbb776
parentcf0ac156c4aba9470a41302c367facfe8b7cb8d4 (diff)
lib/ubsan.c: Remove GCC 5.x workaround
The coreboot toolchain has been using a newer GCC version for a while already. This code is build-tested from commit 13cd145e02e onwards. Change-Id: Ic324b503878c73e4560d4d8f2e0d38ecb595b8fd Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45822 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/lib/ubsan.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c
index 6873f7e238..1037b1b17a 100644
--- a/src/lib/ubsan.c
+++ b/src/lib/ubsan.c
@@ -245,15 +245,7 @@ void __ubsan_handle_vla_bound_not_positive(void *data_raw, void *bound_raw)
ABORT_VARIANT_VP_VP(vla_bound_not_positive);
struct ubsan_float_cast_overflow_data {
-/*
-* TODO: Remove this GCC 5.x compatibility after switching to GCC 6.x. The
-* GCC developers accidentally forgot the source location. Their
-* libubsan probes to see if it looks like a path, but we don't need
-* to maintain compatibility with multiple gcc releases. See below.
-*/
-#if !(defined(__GNUC__) && __GNUC__ < 6)
struct ubsan_source_location location;
-#endif
struct ubsan_type_descriptor *from_type;
struct ubsan_type_descriptor *to_type;
};
@@ -264,11 +256,7 @@ void __ubsan_handle_float_cast_overflow(void *data_raw, void *from_raw)
(struct ubsan_float_cast_overflow_data *)data_raw;
ubsan_value_handle_t from = (ubsan_value_handle_t)from_raw;
(void) from;
-#if !(defined(__GNUC__) && __GNUC__ < 6)
ubsan_abort(&data->location, "float cast overflow");
-#else
- ubsan_abort(((void) data, &unknown_location), "float cast overflow");
-#endif
}
ABORT_VARIANT_VP_VP(float_cast_overflow);