summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2019-05-03 20:07:56 +0530
committerSubrata Banik <subrata.banik@intel.com>2019-05-21 16:20:42 +0000
commit7196be433efc05c8a74b2b82a7689d03d46f2d77 (patch)
tree79a1075ad089fa8af88a62f5a1592a3ef1ebeb52
parentb461865577ed57b4512c75e0becf44b6b7ed0922 (diff)
soc/intel/skylake: Remove redundant mca_configure() in ramstage
This patch removes redundant mca_configure() function call from ramstage to clear machine check exception. First time it's getting called from soc_core_init() function inside cpu.c file. TEST=Build and boot SKL/KBL/AML platform without any machine-check exception. Change-Id: I7e54fd07816c6317588ab6db06365937c4300ccd Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32553 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
-rw-r--r--src/soc/intel/skylake/finalize.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c
index 5d7e1e0034..34738f28f1 100644
--- a/src/soc/intel/skylake/finalize.c
+++ b/src/soc/intel/skylake/finalize.c
@@ -20,7 +20,6 @@
#include <bootstate.h>
#include <console/console.h>
#include <console/post_codes.h>
-#include <cpu/x86/mp.h>
#include <cpu/x86/smm.h>
#include <device/pci.h>
#include <intelblocks/cpulib.h>
@@ -142,9 +141,6 @@ static void soc_finalize(void *unused)
pch_finalize_script(dev);
- printk(BIOS_DEBUG, "Clearing MCA.\n");
- mp_run_on_all_cpus(mca_configure, NULL, 17 * USECS_PER_SEC);
-
soc_lockdown(dev);
printk(BIOS_DEBUG, "Finalizing SMM.\n");