summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@amd.corp-partner.google.com>2023-09-15 12:48:35 -0500
committerFelix Held <felix-coreboot@felixheld.de>2023-09-18 13:16:37 +0000
commit4712f5d56002ec7c2e986c9d1c1914177b52c445 (patch)
tree1a837874d392a4b7dcf543f13fe7e20183f3897e
parenta63a56d57210cd129ea2305019a9f766e2c84429 (diff)
mb/google/skyrim: Re-enable USE_SELECTIVE_GOP_INIT for Skyrim
This reverts commit dc7cc5bc6edf ("mb/google/skyrim: Disable USE_SELECTIVE_GOP_INIT") but limits the default enablement to Skyrim variant only, to allow for continued testing. BUG=b:271850970 BRANCH=skyrim TEST=build/boot ChromeOS R117+ on google/skyrim, verify no display init failures with feature enabled on cold/warm boots or S0i3 resume. Change-Id: I21c70111a5f407a7e8dd1ad1f2c2759ddb91893e Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77964 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
-rw-r--r--src/mainboard/google/skyrim/Kconfig4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index 53dfd53966..437fe89d5f 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -39,6 +39,7 @@ config BOARD_SPECIFIC_OPTIONS
select SOC_AMD_MENDOCINO
select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP
select SOC_AMD_COMMON_BLOCK_USE_ESPI
+ select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP
select SYSTEM_TYPE_LAPTOP
select TPM_GOOGLE_TI50
select PCIEXP_ASPM
@@ -136,6 +137,9 @@ config USE_VARIANT_DXIO_DESCRIPTOR
Enable this to allow a variant to override the dxio descriptor values
in port_descriptors.c
+config USE_SELECTIVE_GOP_INIT
+ default y if CHROMEOS && RUN_FSP_GOP && BOARD_GOOGLE_SKYRIM
+
config VBOOT
select EC_GOOGLE_CHROMEEC_SWITCHES
select VBOOT_LID_SWITCH