diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2020-05-27 23:25:38 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2020-05-28 23:18:22 +0000 |
| commit | 3c93b7e166bb2bcaf1bf17754194604452628c28 (patch) | |
| tree | 73468ee70af5ba7c37d3400a967f73864033d580 | |
| parent | 94c2f76616f5c3da5370e770614aef3a4df51826 (diff) | |
soc/amd/picasso/soc_util: add comment on socket detection problems
At least some Pollock engineering samples return FP5 socket type while
they are in fact FT5 socket type.
Change-Id: I06a19c19374532bfb367fc15c734707d8c7f65a3
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41796
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/amd/picasso/soc_util.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/amd/picasso/soc_util.c b/src/soc/amd/picasso/soc_util.c index 2d10cff6a1..2aa9daa2bc 100644 --- a/src/soc/amd/picasso/soc_util.c +++ b/src/soc/amd/picasso/soc_util.c @@ -12,6 +12,7 @@ #define SOCKET_TYPE_SHIFT 28 #define SOCKET_TYPSE_MASK (0xf << SOCKET_TYPE_SHIFT) +/* some Pollock engineering samples return the wrong socket type */ enum socket_type get_socket_type(void) { uint32_t ebx = cpuid_ebx(0x80000001); @@ -132,6 +133,7 @@ enum silicon_type get_silicon_type(void) return SILICON_UNKNOWN; } +/* some Pollock engineering samples return the wrong socket type and get detected as Dali */ enum soc_type get_soc_type(void) { switch (get_socket_type()) { |