summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2015-05-26 11:26:34 -0500
committerAaron Durbin <adurbin@chromium.org>2015-05-26 19:13:13 +0200
commit7138ee445c713867edd67c20fef10444f7aea6d1 (patch)
treee587ee311f7e2953cfefa1323745e5e0e2877785
parent1de648e272a7da523f05ca9d19226a308c1af852 (diff)
cbmem: remove cbmem_set_top()
Now that the users of cbmem_set_top() always provide a consistent cbmem_top() value there's no need to have cbmem_set_top() around. Therefore, delete it. Change-Id: I0c96e2b8b829eddbeb1fdf755ed59c51ea689d1b Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/10314 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/arch/x86/boot/cbmem.c1
-rw-r--r--src/include/cbmem.h3
-rw-r--r--src/lib/imd_cbmem.c14
3 files changed, 0 insertions, 18 deletions
diff --git a/src/arch/x86/boot/cbmem.c b/src/arch/x86/boot/cbmem.c
index ad8aacbfed..a9127d7c07 100644
--- a/src/arch/x86/boot/cbmem.c
+++ b/src/arch/x86/boot/cbmem.c
@@ -40,7 +40,6 @@ void set_top_of_ram(uint64_t ramtop)
{
backup_top_of_ram(ramtop);
ramtop_pointer = (void *)(uintptr_t)ramtop;
- cbmem_set_top(ramtop_pointer);
}
static inline void *saved_ramtop(void)
diff --git a/src/include/cbmem.h b/src/include/cbmem.h
index 0a7ca89cd4..a8ab3cd61b 100644
--- a/src/include/cbmem.h
+++ b/src/include/cbmem.h
@@ -176,9 +176,6 @@ void cbmem_initialize_empty_id_size(u32 id, u64 size);
* below 4GiB. */
void *cbmem_top(void);
-/* Set the top address for dynamic cbmem. Not for new designs. */
-void cbmem_set_top(void *ramtop);
-
/* Add a cbmem entry of a given size and id. These return NULL on failure. The
* add function performs a find first and do not check against the original
* size. */
diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c
index 6255b18932..d1ff57d96c 100644
--- a/src/lib/imd_cbmem.c
+++ b/src/lib/imd_cbmem.c
@@ -40,20 +40,6 @@ static inline struct imd *cbmem_get_imd(void)
return NULL;
}
-/*
- * x86 !CONFIG_EARLY_CBMEM_INIT platforms need to do the following in ramstage:
- * 1. Call set_top_of_ram() which in turn calls cbmem_set_top().
- * 2. Provide a get_top_of_ram() implementation.
- *
- * CONFIG_EARLY_CBMEM_INIT platforms just need to provide cbmem_top().
- */
-void cbmem_set_top(void *ramtop)
-{
- struct imd *imd = cbmem_get_imd();
-
- imd_handle_init(imd, ramtop);
-}
-
static inline const struct cbmem_entry *imd_to_cbmem(const struct imd_entry *e)
{
return (const struct cbmem_entry *)e;