summaryrefslogtreecommitdiff
path: root/.gitreview
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@google.com>2021-06-09 18:37:42 +0200
committerPatrick Georgi <pgeorgi@google.com>2021-06-10 19:26:46 +0000
commitce55ca2fcaab23010b2f7e310c921f65b037034d (patch)
treeab160de356ce394bded5e4406096eba7dc278d20 /.gitreview
parent36c90179f0c7ef0d11ca78a109bd563b3ec0e0a9 (diff)
tests: Rework mocking facility
Using the linker's --wrap feature has the downside that it only covers references across object files: If foo.c defines a() and b(), with b calling a, --wrap=a does nothing to that call. Instead, use objcopy to mark a weak and global so it can be overridden by another implementation, but only for files originating in src/. That way mocks - implemented in tests/ - become the source of truth. TEST=Had such an issue with get_log_level() in a follow-up commit, and the mock now takes over. Also, all existing unit tests still pass. Change-Id: I99c6d6e44ecfc73366bf464d9c51c7da3f8db388 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55360 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions