From 3f6442749cd9e483e26d03537bd6098d83001629 Mon Sep 17 00:00:00 2001
From: Andrew Lee <anwlee@google.com>
Date: Wed, 26 Aug 2015 17:44:24 -0700
Subject: Only show loading text when downloading VM.

In other cases (eg. buffering), just load without showing the text,
since it will likely appear only for a very short time, and give
the appearance of flickering.

Bug: 22333980
Change-Id: Ic2bbba7a2127654aaf12546b177c465c9311ddc1
---
 src/com/android/dialer/voicemail/VoicemailPlaybackLayout.java    | 6 ------
 src/com/android/dialer/voicemail/VoicemailPlaybackPresenter.java | 6 +++---
 2 files changed, 3 insertions(+), 9 deletions(-)

(limited to 'src/com/android/dialer/voicemail')

diff --git a/src/com/android/dialer/voicemail/VoicemailPlaybackLayout.java b/src/com/android/dialer/voicemail/VoicemailPlaybackLayout.java
index 4a41c0e33..69c075f80 100644
--- a/src/com/android/dialer/voicemail/VoicemailPlaybackLayout.java
+++ b/src/com/android/dialer/voicemail/VoicemailPlaybackLayout.java
@@ -353,12 +353,6 @@ public class VoicemailPlaybackLayout extends LinearLayout
         mStateText.setText(null);
     }
 
-    @Override
-    public void setIsBuffering() {
-        disableUiElements();
-        mStateText.setText(getString(R.string.voicemail_buffering));
-    }
-
     @Override
     public void setIsFetchingContent() {
         disableUiElements();
diff --git a/src/com/android/dialer/voicemail/VoicemailPlaybackPresenter.java b/src/com/android/dialer/voicemail/VoicemailPlaybackPresenter.java
index 3479dce90..3f5a489ce 100644
--- a/src/com/android/dialer/voicemail/VoicemailPlaybackPresenter.java
+++ b/src/com/android/dialer/voicemail/VoicemailPlaybackPresenter.java
@@ -85,7 +85,6 @@ public class VoicemailPlaybackPresenter
         void onSpeakerphoneOn(boolean on);
         void setClipPosition(int clipPositionInMillis, int clipLengthInMillis);
         void setFetchContentTimeout();
-        void setIsBuffering();
         void setIsFetchingContent();
         void setPresenter(VoicemailPlaybackPresenter presenter, Uri voicemailUri);
     }
@@ -346,7 +345,6 @@ public class VoicemailPlaybackPresenter
      * a request to fetch the content asynchronously via {@link #requestContent()}.
      */
     private void checkForContent() {
-        mView.setIsFetchingContent();
         mAsyncTaskExecutor.submit(Tasks.CHECK_FOR_CONTENT, new AsyncTask<Void, Void, Boolean>() {
             @Override
             public Boolean doInBackground(Void... params) {
@@ -403,6 +401,8 @@ public class VoicemailPlaybackPresenter
 
         mFetchResultHandler = new FetchResultHandler(new Handler(), mVoicemailUri);
 
+        mView.setIsFetchingContent();
+
         // Send voicemail fetch request.
         Intent intent = new Intent(VoicemailContract.ACTION_FETCH_VOICEMAIL, mVoicemailUri);
         mContext.sendBroadcast(intent);
@@ -485,7 +485,7 @@ public class VoicemailPlaybackPresenter
             mMediaPlayer = null;
         }
 
-        mView.setIsBuffering();
+        mView.disableUiElements();
         mIsPrepared = false;
 
         try {
-- 
cgit v1.2.3