From 55733814f213809baaa8eaa8984ff026bdb08b4e Mon Sep 17 00:00:00 2001 From: Anthony Lee Date: Tue, 30 Sep 2014 15:55:31 -0700 Subject: Fix HTTP request to a report bad caller ID entry in the call log (1/2) A few things needed to change to fix this bug. 1. Add object ID to ContactInfo and make sure that it is persisted 2. Adding a new row means migration from older versions of DBs 3. Fix logic that determines if we can report a given call log entry since the strategy of using isExternal() is not valid. UI impact. 4. Fix the HTTP request that is generated to include a valid object ID intead of using the source ID. Bug: 17692726 Change-Id: If541fea963837118b7466b6c59f453103cdbdc4a --- src/com/android/dialer/service/CachedNumberLookupService.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/com/android/dialer/service') diff --git a/src/com/android/dialer/service/CachedNumberLookupService.java b/src/com/android/dialer/service/CachedNumberLookupService.java index 2fec45cd6..a3782f162 100644 --- a/src/com/android/dialer/service/CachedNumberLookupService.java +++ b/src/com/android/dialer/service/CachedNumberLookupService.java @@ -34,8 +34,7 @@ public interface CachedNumberLookupService { public boolean isCacheUri(String uri); public boolean isBusiness(int sourceType); - - public boolean isExternal(int sourceType); + public boolean canReportAsInvalid(int sourceType, String objectId); public boolean addPhoto(Context context, String number, byte[] photo); -- cgit v1.2.3