From 8cda8b0f242808fc4e13765498e7568d9bece954 Mon Sep 17 00:00:00 2001
From: Yorke Lee <yorkelee@google.com>
Date: Wed, 16 Sep 2015 12:40:00 -0700
Subject: Improve clickability of search bar buttons

Move some padding around to increase the touch area of
the voice search and overflow menu buttons
Replace microphone icon with correctly-sized one (24dp)
per material design guidelines

Bug: 22958299

Change-Id: I79ac81738eb4efbcdaf7d211afbec6fba6344c7f
---
 res/drawable-hdpi/ic_mic_grey600.png    | Bin 0 -> 377 bytes
 res/drawable-hdpi/ic_voice_search.png   | Bin 1249 -> 0 bytes
 res/drawable-mdpi/ic_mic_grey600.png    | Bin 0 -> 252 bytes
 res/drawable-mdpi/ic_voice_search.png   | Bin 912 -> 0 bytes
 res/drawable-xhdpi/ic_mic_grey600.png   | Bin 0 -> 454 bytes
 res/drawable-xhdpi/ic_voice_search.png  | Bin 1572 -> 0 bytes
 res/drawable-xxhdpi/ic_mic_grey600.png  | Bin 0 -> 631 bytes
 res/drawable-xxhdpi/ic_voice_search.png | Bin 2075 -> 0 bytes
 res/drawable-xxxhdpi/ic_mic_grey600.png | Bin 0 -> 853 bytes
 res/layout/search_edittext.xml          |  14 +++++++-------
 res/values/dimens.xml                   |   2 --
 11 files changed, 7 insertions(+), 9 deletions(-)
 create mode 100644 res/drawable-hdpi/ic_mic_grey600.png
 delete mode 100644 res/drawable-hdpi/ic_voice_search.png
 create mode 100644 res/drawable-mdpi/ic_mic_grey600.png
 delete mode 100644 res/drawable-mdpi/ic_voice_search.png
 create mode 100644 res/drawable-xhdpi/ic_mic_grey600.png
 delete mode 100644 res/drawable-xhdpi/ic_voice_search.png
 create mode 100644 res/drawable-xxhdpi/ic_mic_grey600.png
 delete mode 100644 res/drawable-xxhdpi/ic_voice_search.png
 create mode 100644 res/drawable-xxxhdpi/ic_mic_grey600.png

(limited to 'res')

diff --git a/res/drawable-hdpi/ic_mic_grey600.png b/res/drawable-hdpi/ic_mic_grey600.png
new file mode 100644
index 000000000..4b67cf71a
Binary files /dev/null and b/res/drawable-hdpi/ic_mic_grey600.png differ
diff --git a/res/drawable-hdpi/ic_voice_search.png b/res/drawable-hdpi/ic_voice_search.png
deleted file mode 100644
index 9631d3e3d..000000000
Binary files a/res/drawable-hdpi/ic_voice_search.png and /dev/null differ
diff --git a/res/drawable-mdpi/ic_mic_grey600.png b/res/drawable-mdpi/ic_mic_grey600.png
new file mode 100644
index 000000000..2310c734a
Binary files /dev/null and b/res/drawable-mdpi/ic_mic_grey600.png differ
diff --git a/res/drawable-mdpi/ic_voice_search.png b/res/drawable-mdpi/ic_voice_search.png
deleted file mode 100644
index af58538d9..000000000
Binary files a/res/drawable-mdpi/ic_voice_search.png and /dev/null differ
diff --git a/res/drawable-xhdpi/ic_mic_grey600.png b/res/drawable-xhdpi/ic_mic_grey600.png
new file mode 100644
index 000000000..a9a83b329
Binary files /dev/null and b/res/drawable-xhdpi/ic_mic_grey600.png differ
diff --git a/res/drawable-xhdpi/ic_voice_search.png b/res/drawable-xhdpi/ic_voice_search.png
deleted file mode 100644
index 6e5d8115b..000000000
Binary files a/res/drawable-xhdpi/ic_voice_search.png and /dev/null differ
diff --git a/res/drawable-xxhdpi/ic_mic_grey600.png b/res/drawable-xxhdpi/ic_mic_grey600.png
new file mode 100644
index 000000000..07128dd82
Binary files /dev/null and b/res/drawable-xxhdpi/ic_mic_grey600.png differ
diff --git a/res/drawable-xxhdpi/ic_voice_search.png b/res/drawable-xxhdpi/ic_voice_search.png
deleted file mode 100644
index 4e72f6947..000000000
Binary files a/res/drawable-xxhdpi/ic_voice_search.png and /dev/null differ
diff --git a/res/drawable-xxxhdpi/ic_mic_grey600.png b/res/drawable-xxxhdpi/ic_mic_grey600.png
new file mode 100644
index 000000000..b7403ff22
Binary files /dev/null and b/res/drawable-xxxhdpi/ic_mic_grey600.png differ
diff --git a/res/layout/search_edittext.xml b/res/layout/search_edittext.xml
index 61406a197..8eda6960c 100644
--- a/res/layout/search_edittext.xml
+++ b/res/layout/search_edittext.xml
@@ -17,7 +17,6 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:paddingStart="@dimen/search_box_left_padding"
-        android:paddingEnd="@dimen/search_box_right_padding"
         android:gravity="center_vertical"
         android:orientation="horizontal">
 
@@ -25,8 +24,8 @@
             android:id="@+id/search_magnifying_glass"
             android:layout_height="@dimen/search_box_icon_size"
             android:layout_width="@dimen/search_box_icon_size"
-            android:layout_margin="@dimen/search_box_icon_margin"
             android:padding="@dimen/search_box_search_icon_padding"
+            android:scaleType="center"
             android:src="@drawable/ic_ab_search"
             android:importantForAccessibility="no"
             android:tint="@color/searchbox_icon_tint" />
@@ -45,10 +44,10 @@
 
         <ImageView
             android:id="@+id/voice_search_button"
-            android:layout_height="@dimen/search_box_icon_size"
             android:layout_width="@dimen/search_box_icon_size"
-            android:layout_margin="@dimen/search_box_icon_margin"
-            android:src="@drawable/ic_voice_search"
+            android:layout_height="match_parent"
+            android:src="@drawable/ic_mic_grey600"
+            android:scaleType="center"
             android:clickable="true"
             android:contentDescription="@string/description_start_voice_search"
             android:background="?android:attr/selectableItemBackgroundBorderless"
@@ -57,8 +56,9 @@
         <ImageButton
             android:id="@+id/dialtacts_options_menu_button"
             android:layout_width="@dimen/search_box_icon_size"
-            android:layout_height="@dimen/search_box_icon_size"
-            android:layout_margin="@dimen/search_box_icon_margin"
+            android:layout_height="match_parent"
+            android:paddingEnd="@dimen/search_box_right_padding"
+            android:scaleType="center"
             android:background="?android:attr/selectableItemBackgroundBorderless"
             android:src="@drawable/ic_overflow_menu"
             android:contentDescription="@string/action_menu_overflow_description"
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index 776cd1150..e6d971bff 100644
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -96,8 +96,6 @@
     <dimen name="search_box_left_padding">8dp</dimen>
     <!-- Search box interior padding - right -->
     <dimen name="search_box_right_padding">8dp</dimen>
-    <!-- Padding around the icon in the search box. -->
-    <dimen name="search_box_icon_margin">4dp</dimen>
     <dimen name="search_box_search_icon_padding">2dp</dimen>
     <dimen name="search_box_collapsed_text_margin_left">22dp</dimen>
     <dimen name="search_list_padding_top">16dp</dimen>
-- 
cgit v1.2.3