From 8d4afb83b0c19bf886b282de21357c9fe3be1869 Mon Sep 17 00:00:00 2001 From: twyen Date: Thu, 3 May 2018 16:41:54 -0700 Subject: Clear NewCallLogViewHolder.onClickListener if row is not callable. Previously the listener is not cleared, and clicking on a private will call whatever the view was previously bound to. TEST=TAP Bug: 79219109 Test: TAP PiperOrigin-RevId: 195332291 Change-Id: I4806ab659099dc7986b90c68f2e52d8efd4f5f5b --- java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java | 1 + 1 file changed, 1 insertion(+) (limited to 'java') diff --git a/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java b/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java index 44a08c75e..c02d80ede 100644 --- a/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java +++ b/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java @@ -268,6 +268,7 @@ final class NewCallLogViewHolder extends RecyclerView.ViewHolder { private void setOnClickListenerForRow(CoalescedRow row) { if (!PhoneNumberHelper.canPlaceCallsTo( row.getNumber().getNormalizedNumber(), row.getNumberPresentation())) { + itemView.setOnClickListener(null); return; } itemView.setOnClickListener(view -> CallLogRowActions.startCallForRow(activity, row)); -- cgit v1.2.3