From 763ce4404ae8e4199da719359a1b01389884cec4 Mon Sep 17 00:00:00 2001 From: linyuh Date: Fri, 4 May 2018 10:54:12 -0700 Subject: Remove TODOs for showing SIM info in the bottom sheet & call details. Bug: 74522027 Test: None PiperOrigin-RevId: 195439124 Change-Id: Ibab0bc7e58bd1b23255d9af476c5b98ed89f13fa --- java/com/android/dialer/calldetails/CallDetailsHeaderViewHolder.java | 2 -- .../com/android/dialer/calldetails/proto/call_details_header_info.proto | 2 -- .../historyitemactions/history_item_bottom_sheet_header_info.proto | 2 -- 3 files changed, 6 deletions(-) (limited to 'java') diff --git a/java/com/android/dialer/calldetails/CallDetailsHeaderViewHolder.java b/java/com/android/dialer/calldetails/CallDetailsHeaderViewHolder.java index cb84a28c2..cd1752d74 100644 --- a/java/com/android/dialer/calldetails/CallDetailsHeaderViewHolder.java +++ b/java/com/android/dialer/calldetails/CallDetailsHeaderViewHolder.java @@ -192,8 +192,6 @@ public class CallDetailsHeaderViewHolder extends RecyclerView.ViewHolder nameView.setText(headerInfo.getPrimaryText()); numberView.setText(headerInfo.getSecondaryText()); - // TODO(a bug): show SIM info in the TextView returned by getNetworkView(). - setCallbackAction(callbackAction); } diff --git a/java/com/android/dialer/calldetails/proto/call_details_header_info.proto b/java/com/android/dialer/calldetails/proto/call_details_header_info.proto index ea7ba1e72..e2532d504 100644 --- a/java/com/android/dialer/calldetails/proto/call_details_header_info.proto +++ b/java/com/android/dialer/calldetails/proto/call_details_header_info.proto @@ -31,6 +31,4 @@ message CallDetailsHeaderInfo { // "Blocked • Mobile • 555-1234", and // "Spam • Mobile • 555-1234". optional string secondary_text = 4; - - // TODO(a bug): Add SIM info. } \ No newline at end of file diff --git a/java/com/android/dialer/historyitemactions/history_item_bottom_sheet_header_info.proto b/java/com/android/dialer/historyitemactions/history_item_bottom_sheet_header_info.proto index ef71ecd7e..04d9f2259 100644 --- a/java/com/android/dialer/historyitemactions/history_item_bottom_sheet_header_info.proto +++ b/java/com/android/dialer/historyitemactions/history_item_bottom_sheet_header_info.proto @@ -36,6 +36,4 @@ message HistoryItemBottomSheetHeaderInfo { // "Blocked • Mobile • 555-1234", and // "Spam • Mobile • 555-1234". optional string secondary_text = 4; - - // TODO(a bug): Add SIM info. } -- cgit v1.2.3